Re: [PATCH] tools/perf: Fix a build error on arm64 with clang

Arnaldo Carvalho de Melo
2021-05-09T12:51:02Z

Em Fri, May 07, 2021 at 05:54:35PM +0900, Masami Hiramatsu escreveu:
> Since Clang's -Wmissing-field-initializers warns if a data
> structure is initialized with a signle NULL as below,
>
> ----
> tools/perf $ make CC=clang LLVM=1
> ...
> arch/arm64/util/kvm-stat.c:74:9: error: missing field 'ops' initializer [-Werror,-Wmissing-field-initializers]
> { NULL },
> ^
> 1 error generated.
> ----

Thanks, applied.

- Arnaldo

> add another field initializer expressly as same as other
> arch's kvm-stat.c code.
>
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> tools/perf/arch/arm64/util/kvm-stat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/arch/arm64/util/kvm-stat.c b/tools/perf/arch/arm64/util/kvm-stat.c
> index 2303256b7d05..73d18e0ed6f6 100644
> --- a/tools/perf/arch/arm64/util/kvm-stat.c
> +++ b/tools/perf/arch/arm64/util/kvm-stat.c
> @@ -71,7 +71,7 @@ struct kvm_reg_events_ops kvm_reg_events_ops[] = {
> .name = "vmexit",
> .ops = &exit_events,
> },
> - { NULL },
> + { NULL, NULL },
> };
>
> const char * const kvm_skip_events[] = {
>

--

- Arnaldo