From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754256AbcCBJGV (ORCPT <rfc822;w@1wt.eu>);
	Wed, 2 Mar 2016 04:06:21 -0500
Received: from mout.kundenserver.de ([217.72.192.73]:56460 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753416AbcCBJGF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 2 Mar 2016 04:06:05 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        Kyle McMartin <kyle@mcmartin.ca>,
        RTCLINUX <rtc-linux@googlegroups.com>,
        Alessandro Zummo <a.zummo@towertech.it>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        Linux-sh list <linux-sh@vger.kernel.org>,
        Parisc List <linux-parisc@vger.kernel.org>,
        linux-m68k <linux-m68k@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] rtc: generic: allow building on all architectures
Date: Wed, 02 Mar 2016 10:05:18 +0100
Message-ID: <1620536.OtjnSSLgCT@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CAMuHMdW5+jZ1n9WnCwBrGSGjUa8ziNTTqf-H15EFTQC_iwnw+Q@mail.gmail.com>
References: <1456851608-3374907-1-git-send-email-arnd@arndb.de> <1456851608-3374907-2-git-send-email-arnd@arndb.de> <CAMuHMdW5+jZ1n9WnCwBrGSGjUa8ziNTTqf-H15EFTQC_iwnw+Q@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:of3NxZWSdf9LSuKmjrteQirvXyDuQsXTses1t18z8UoKSbW+eI7
 LEyDKaSvVgotbpNEruzoyWKsBDM6ht35Tjkn+mxyYdvSr2WjoxDcwSKeGhPECzfujYc/Y0L
 1WeKi0zaALNePLiKavP1+yRLakZ+q5CqQnFgC9MNukg99lXjGvCj41jfOiRessxRADs2svc
 YHRo2/AAQw4Sbowna3DKA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:BXMOME6xkgA=:BUOEs1lNzYpPcf7Q08LVBG
 RfGy2myakPvdrL+ulo42CUwMlgtRKtRhq4Iii4H7YeVU0CpgbKzb1Gjg4hX0dNEuMat8D/xQX
 XrlRM+xYdtQKDlDZcBOlm4r/zCf+i5LARNdAqw4/NcK7BdBr4kQ/Igd3C4Wt5XIowX6taSYCm
 aENOq7QqJTom0p8mDkKJtUzSa48TWgp1HsqPYeOzOZOqcZb3QFq53RSiI3YcECaYnf6pyOQkG
 mjwVi+mOGSdorK/dV1TEH/Qbooh9OzD8xC5dr4rHk3Od9NgLtpylf9Qunf6KTUtDuFvpAP2Ev
 jA1XLSt9E0IEgVK6DmCHmVN+Cxk7Vlgfyq8MSQ7yifLM0iv27IaK0j2iNJ+g/L0ptaj0mZ57K
 qQYuhqlDsJCQbhdkCFkv36ik/yO3RcMRWkH5pxvDcJBW0t7SJKM0Pd9bWM07l3rsAdvMZHboS
 7M8q8MHOH6IVLit8yVHOrRXlR1Qtp2CDIbRp5+85sMC+WUAe42ijegYZ+v5QiQ17s/zADxh3N
 di+r2YwXQwpoWTV1HoY8LyILruNjkBgS/hnQxWOZicv/8w5HGKykZZLrQ6+luD+P5TiBPiLeJ
 oEmb4LvrMoj6VN4/8r3Ns35a3t6WXRWASGLuqU5wL2aM7Kvwgk9EikmJ0DuRGz9awQ3HKIfpo
 geshCE3oo8/m+Qz5RZ9HrpZPDnl4S+jkKQs+45qTteLvyXbN68y+dEUzUUwa03ztfhRCTLutt
 LiCA1HaRoZ0LGGN1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday 02 March 2016 09:57:27 Geert Uytterhoeven wrote:
> > @@ -33,13 +35,21 @@ static const struct rtc_class_ops generic_rtc_ops = {
> >         .read_time = generic_get_time,
> >         .set_time = generic_set_time,
> >  };
> > +#else
> > +#define generic_rtc_ops *(struct rtc_class_ops*)NULL
> > +#endif
> >
> >  static int __init generic_rtc_probe(struct platform_device *dev)
> >  {
> >         struct rtc_device *rtc;
> > +       const struct rtc_class_ops *ops;
> > +
> > +       ops = dev_get_platdata(&dev->dev);
> > +       if (!ops)
> > +               ops = &generic_rtc_ops;
> 
> I hope no compiler version treats "&*(struct rtc_class_ops*)NULL" as
> undefined behavior?

It's a bit odd, but I think it's syntactically correct C, and not
much too different from 

#define offsetof(TYPE, MEMBER)  ((size_t)&((TYPE *)0)->MEMBER)

is it? My last patch gets rid of it again.

	Arnd