From: patchwork-bot+netdevbpf@kernel.org
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: bpf@vger.kernel.org, daniel@iogearbox.net, toke@redhat.com,
john.fastabend@gmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, brouer@redhat.com
Subject: Re: [PATCH bpf-next] bpf/devmap: remove drops variable from bq_xmit_all()
Date: Fri, 28 May 2021 20:20:03 +0000 [thread overview]
Message-ID: <162223320364.3755.2019874007174661527.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210528024356.24333-1-liuhangbin@gmail.com>
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Thu, 27 May 2021 22:43:56 -0400 you wrote:
> As Colin pointed out, the first drops assignment after declaration will
> be overwritten by the second drops assignment before using, which makes
> it useless.
>
> Since the drops variable will be used only once. Just remove it and
> use "cnt - sent" in trace_xdp_devmap_xmit()
>
> [...]
Here is the summary with links:
- [bpf-next] bpf/devmap: remove drops variable from bq_xmit_all()
https://git.kernel.org/bpf/bpf-next/c/e8e0f0f48478
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-05-28 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 2:43 [PATCH bpf-next] bpf/devmap: remove drops variable from bq_xmit_all() Hangbin Liu
2021-05-28 4:02 ` John Fastabend
2021-05-28 20:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162223320364.3755.2019874007174661527.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox