* [PATCH] DT: S5P: If detected device tree skip irq init
@ 2013-09-23 10:13 Mateusz Krawczuk
2013-09-23 12:32 ` Tomasz Figa
0 siblings, 1 reply; 2+ messages in thread
From: Mateusz Krawczuk @ 2013-09-23 10:13 UTC (permalink / raw)
To: kgene.kim
Cc: ben-linux, linux, linux-arm-kernel, linux-samsung-soc,
linux-kernel, t.figa, m.szyprowski, Mateusz Krawczuk,
Kyungmin Park
It prevents from executing code already called by device tree.
Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/plat-samsung/s5p-irq-eint.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/plat-samsung/s5p-irq-eint.c b/arch/arm/plat-samsung/s5p-irq-eint.c
index faa6516..ebee4dc 100644
--- a/arch/arm/plat-samsung/s5p-irq-eint.c
+++ b/arch/arm/plat-samsung/s5p-irq-eint.c
@@ -16,6 +16,7 @@
#include <linux/device.h>
#include <linux/gpio.h>
#include <linux/irqchip/arm-vic.h>
+#include <linux/of.h>
#include <plat/regs-irqtype.h>
@@ -202,6 +203,9 @@ static int __init s5p_init_irq_eint(void)
{
int irq;
+ if (of_have_populated_dt())
+ return -ENODEV;
+
for (irq = IRQ_EINT(0); irq <= IRQ_EINT(15); irq++)
irq_set_chip(irq, &s5p_irq_vic_eint);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] DT: S5P: If detected device tree skip irq init
2013-09-23 10:13 [PATCH] DT: S5P: If detected device tree skip irq init Mateusz Krawczuk
@ 2013-09-23 12:32 ` Tomasz Figa
0 siblings, 0 replies; 2+ messages in thread
From: Tomasz Figa @ 2013-09-23 12:32 UTC (permalink / raw)
To: Mateusz Krawczuk
Cc: kgene.kim, ben-linux, linux, linux-arm-kernel, linux-samsung-soc,
linux-kernel, m.szyprowski, Kyungmin Park
On Monday 23 of September 2013 12:13:42 Mateusz Krawczuk wrote:
> It prevents from executing code already called by device tree.
I'd say that it prevents from executing code handling things that, when
booting with device tree, are already handled by other code, namely the
pinctrl-exynos driver.
>
> Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/s5p-irq-eint.c | 4 ++++
> 1 file changed, 4 insertions(+)
Otherwise, after fixing commit message:
Acked-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-23 12:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 10:13 [PATCH] DT: S5P: If detected device tree skip irq init Mateusz Krawczuk
2013-09-23 12:32 ` Tomasz Figa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox