From: "cy_huang(黃啟原)" <cy_huang@richtek.com>
To: "broonie@kernel.org" <broonie@kernel.org>,
"axel.lin@ingics.com" <axel.lin@ingics.com>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: rt6160: Remove vsel_active_low from struct rt6160_priv
Date: Tue, 15 Jun 2021 15:24:27 +0000 [thread overview]
Message-ID: <1623770667.4571.4.camel@richtek.com> (raw)
In-Reply-To: <162376572819.36399.17993990572863185568.b4-ty@kernel.org>
Hi, Mark/Axel:
No, you may misunderstand it.
If vsel active is high, the normal voltage output register is vselh register,
and the suspend voltage is vsell register. Else, reverse.
Axel's change will cause the normal/suspend voltage be configured for the same
register. It's not for our reference usage.
> On Tue, 15 Jun 2021 18:39:47 +0800, Axel Lin wrote:
> >
> > Use a local variable instead is enough, this simplifies the code.
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-
> next
>
> Thanks!
>
> [1/1] regulator: rt6160: Remove vsel_active_low from struct rt6160_priv
> commit: f3f4f37d53be578c65dd32a1ffad432b33aef236
>
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
>
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
>
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
>
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
>
> Thanks,
> Mark
************* Email Confidentiality Notice ********************
The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!
next prev parent reply other threads:[~2021-06-15 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 10:39 [PATCH] regulator: rt6160: Remove vsel_active_low from struct rt6160_priv Axel Lin
2021-06-15 15:15 ` Mark Brown
2021-06-15 15:24 ` cy_huang(黃啟原) [this message]
2021-06-15 15:34 ` Mark Brown
2021-06-15 16:04 ` cy_huang(黃啟原)
2021-06-15 16:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623770667.4571.4.camel@richtek.com \
--to=cy_huang@richtek.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox