From: kan.liang@linux.intel.com
To: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org
Cc: acme@kernel.org, mark.rutland@arm.com, ak@linux.intel.com,
alexander.shishkin@linux.intel.com, namhyung@kernel.org,
jolsa@redhat.com, Kan Liang <kan.liang@linux.intel.com>
Subject: [PATCH 3/4] perf: Check the supported CPU of an event
Date: Wed, 16 Jun 2021 11:55:33 -0700 [thread overview]
Message-ID: <1623869734-133974-4-git-send-email-kan.liang@linux.intel.com> (raw)
In-Reply-To: <1623869734-133974-1-git-send-email-kan.liang@linux.intel.com>
From: Kan Liang <kan.liang@linux.intel.com>
All architectures, which support the filter_match callback, check
whether an event is schedulable on the current CPU. Since the
supported_cpus is moved to struct pmu, the check can be done in the
generic code. The filter_match callback can be avoided for some
architecture, e.g., x86.
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
---
kernel/events/core.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index b172f54..7140f40 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -2225,9 +2225,19 @@ static bool is_orphaned_event(struct perf_event *event)
return event->state == PERF_EVENT_STATE_DEAD;
}
+static __always_inline bool pmu_can_sched_on_this_cpu(struct pmu *pmu)
+{
+ return cpumask_empty(&pmu->supported_cpus) ||
+ cpumask_test_cpu(smp_processor_id(), &pmu->supported_cpus);
+}
+
static inline int __pmu_filter_match(struct perf_event *event)
{
struct pmu *pmu = event->pmu;
+
+ if (!pmu_can_sched_on_this_cpu(pmu))
+ return 0;
+
return pmu->filter_match ? pmu->filter_match(event) : 1;
}
@@ -3825,7 +3835,7 @@ static inline void perf_event_context_update_hybrid(struct perf_event_context *c
{
struct pmu *pmu = ctx->pmu;
- if (cpumask_empty(&pmu->supported_cpus) || cpumask_test_cpu(smp_processor_id(), &pmu->supported_cpus))
+ if (pmu_can_sched_on_this_cpu(pmu))
return;
rcu_read_lock();
--
2.7.4
next prev parent reply other threads:[~2021-06-16 19:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 18:55 [PATCH 0/4] perf: Fix the ctx->pmu for a hybrid system kan.liang
2021-06-16 18:55 ` [PATCH 1/4] perf: Update " kan.liang
2021-06-16 18:55 ` [PATCH 2/4] perf/x86: Fix the x86_pmu_start WARNING on " kan.liang
2021-06-16 18:55 ` kan.liang [this message]
2021-06-16 18:55 ` [PATCH 4/4] perf/x86: Remove filter_match callback kan.liang
2021-06-17 10:23 ` [PATCH 0/4] perf: Fix the ctx->pmu for a hybrid system Peter Zijlstra
2021-06-17 11:33 ` Peter Zijlstra
2021-06-17 14:10 ` Liang, Kan
2021-06-17 19:32 ` Peter Zijlstra
2021-06-18 13:54 ` Liang, Kan
2021-06-24 7:09 ` [tip: perf/core] perf: Fix task context PMU for Hetero tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623869734-133974-4-git-send-email-kan.liang@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox