From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754667AbbI3QkU (ORCPT ); Wed, 30 Sep 2015 12:40:20 -0400 Received: from mail-qk0-f177.google.com ([209.85.220.177]:33421 "EHLO mail-qk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754242AbbI3QkP (ORCPT ); Wed, 30 Sep 2015 12:40:15 -0400 From: Paul Moore To: Rasmus Villemoes Cc: Stephen Smalley , Eric Paris , James Morris , "Serge E. Hallyn" , selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] selinux: use kstrdup() in security_get_bools() Date: Wed, 30 Sep 2015 12:40:13 -0400 Message-ID: <1624521.andICT3hTI@sifl> User-Agent: KMail/4.14.10 (Linux/4.1.5-gentoo; KDE/4.14.12; x86_64; ; ) In-Reply-To: <1443220459-11042-5-git-send-email-linux@rasmusvillemoes.dk> References: <1443220459-11042-1-git-send-email-linux@rasmusvillemoes.dk> <1443220459-11042-5-git-send-email-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, September 26, 2015 12:34:18 AM Rasmus Villemoes wrote: > This is much simpler. > > Signed-off-by: Rasmus Villemoes > --- > security/selinux/ss/services.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) Applied. > diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c > index 994c824a34c6..aa2bdcb20848 100644 > --- a/security/selinux/ss/services.c > +++ b/security/selinux/ss/services.c > @@ -2609,18 +2609,12 @@ int security_get_bools(int *len, char ***names, int > **values) goto err; > > for (i = 0; i < *len; i++) { > - size_t name_len; > - > (*values)[i] = policydb.bool_val_to_struct[i]->state; > - name_len = strlen(sym_name(&policydb, SYM_BOOLS, i)) + 1; > > rc = -ENOMEM; > - (*names)[i] = kmalloc(sizeof(char) * name_len, GFP_ATOMIC); > + (*names)[i] = kstrdup(sym_name(&policydb, SYM_BOOLS, i), GFP_ATOMIC); > if (!(*names)[i]) > goto err; > - > - strncpy((*names)[i], sym_name(&policydb, SYM_BOOLS, i), name_len); > - (*names)[i][name_len - 1] = 0; > } > rc = 0; > out: -- paul moore www.paul-moore.com