From: patchwork-bot+netdevbpf@kernel.org
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: netdev@vger.kernel.org, linyunsheng@huawei.com,
alexanderduyck@fb.com, brouer@redhat.com, davem@davemloft.net,
kuba@kernel.org, alobakin@pm.me, jonathan.lemon@gmail.com,
willemb@google.com, linmiaohe@huawei.com, gnault@redhat.com,
cong.wang@bytedance.com, mcroce@microsoft.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1 v3] skbuff: Fix a potential race while recycling page_pool packets
Date: Fri, 16 Jul 2021 18:50:04 +0000 [thread overview]
Message-ID: <162646140463.32424.6557928030854719030.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210716070222.106422-1-ilias.apalodimas@linaro.org>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 16 Jul 2021 10:02:18 +0300 you wrote:
> As Alexander points out, when we are trying to recycle a cloned/expanded
> SKB we might trigger a race. The recycling code relies on the
> pp_recycle bit to trigger, which we carry over to cloned SKBs.
> If that cloned SKB gets expanded or if we get references to the frags,
> call skb_release_data() and overwrite skb->head, we are creating separate
> instances accessing the same page frags. Since the skb_release_data()
> will first try to recycle the frags, there's a potential race between
> the original and cloned SKB, since both will have the pp_recycle bit set.
>
> [...]
Here is the summary with links:
- [1/1,v3] skbuff: Fix a potential race while recycling page_pool packets
https://git.kernel.org/netdev/net/c/2cc3aeb5eccc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-07-16 18:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 7:02 [PATCH 1/1 v3] skbuff: Fix a potential race while recycling page_pool packets Ilias Apalodimas
2021-07-16 18:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162646140463.32424.6557928030854719030.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=alobakin@pm.me \
--cc=brouer@redhat.com \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=gnault@redhat.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=mcroce@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox