Re: [PATCH] net/mlx4: make the array states static const, makes object smaller

Tariq Toukan
2021-08-02T10:39:50Z

On 8/1/2021 6:37 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array states on the stack but instead it
> static const. Makes the object code smaller by 79 bytes.
>
> Before:
> text data bss dec hex filename
> 21309 8304 192 29805 746d drivers/net/ethernet/mellanox/mlx4/qp.o
>
> After:
> text data bss dec hex filename
> 21166 8368 192 29726 741e drivers/net/ethernet/mellanox/mlx4/qp.o
>
> (gcc version 10.2.0)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/qp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/qp.c b/drivers/net/ethernet/mellanox/mlx4/qp.c
> index 427e7a31862c..2584bc038f94 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/qp.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/qp.c
> @@ -917,7 +917,7 @@ int mlx4_qp_to_ready(struct mlx4_dev *dev, struct mlx4_mtt *mtt,
> {
> int err;
> int i;
> - enum mlx4_qp_state states[] = {
> + static const enum mlx4_qp_state states[] = {
> MLX4_QP_STATE_RST,
> MLX4_QP_STATE_INIT,
> MLX4_QP_STATE_RTR,
>

Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Thanks for your patch.

Regards,
Tariq