From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Leo Wang <leo.jt.wang@gmail.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
george.kw.lee@fii-foxconn.com, bruce.jy.hung@fii-foxconn.com,
leo.jt.wang@fii-foxconn.com
Subject: Re: [PATCH] ARM: dts: aspeed: clemente: add MCTP over I2C support
Date: Mon, 22 Sep 2025 13:16:48 +0930 [thread overview]
Message-ID: <16281e86d3cf5c97fcb59e73472dc8edca50c484.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20250918-leo-dts-transceiver-v1-1-3e2580325edc@gmail.com>
Hi Leo,
On Thu, 2025-09-18 at 17:43 +0800, Leo Wang wrote:
> Enable MCTP communication on the Meta Clemente BMC board:
>
> - Add an MCTP I2C controller node at address 0x10 on I2C0
> - Mark selected I2C mux channels as MCTP controllers
> - Remove unused "i2c-mux-idle-disconnect" properties
>
> This allows MCTP devices to be discovered and used for
> management communication on the Clemente platform.
This description covers details we can see in the patch itself. Can you
please rather describe the motivation and any related considerations,
e.g. answer:
* What devices will you be managing via MCTP?
* How do they affect the function of the platform?
- Alternatively, how does _not_ having the MCTP capability to manage
them impact the function of the platform?
The general advice provided here might be helpful:
https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
Andrew
prev parent reply other threads:[~2025-09-22 3:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 9:43 [PATCH] ARM: dts: aspeed: clemente: add MCTP over I2C support Leo Wang
2025-09-22 3:46 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16281e86d3cf5c97fcb59e73472dc8edca50c484.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=bruce.jy.hung@fii-foxconn.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=george.kw.lee@fii-foxconn.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=leo.jt.wang@fii-foxconn.com \
--cc=leo.jt.wang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox