Re: [PATCH v4 07/10] tools/bootconfig: Support per-group/all event enabling option

Masami Hiramatsu
2021-08-14T03:35:55Z

On Tue, 10 Aug 2021 11:07:58 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>

Oops, I missed the changelog for this patch.

-----
Add group or all event enabling syntax support to bconf2ftrace.sh.
User can pass a bootconfig file which includes

ftrace[.instance.INSTANCE].event.enable

and

ftrace[.instance.INSTANCE].event.GROUP.enable

correctly.
-----

Steve, should I update the patch and resend the series?

Thank you,

> ---
> tools/bootconfig/scripts/bconf2ftrace.sh | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/tools/bootconfig/scripts/bconf2ftrace.sh b/tools/bootconfig/scripts/bconf2ftrace.sh
> index feb30c2c7881..651049c782c0 100755
> --- a/tools/bootconfig/scripts/bconf2ftrace.sh
> +++ b/tools/bootconfig/scripts/bconf2ftrace.sh
> @@ -101,6 +101,12 @@ setup_event() { # prefix group event [instance]
> else
> eventdir="$TRACEFS/events/$2/$3"
> fi
> + # group enable
> + if [ "$3" = "enable" ]; then
> + run_cmd "echo 1 > ${eventdir}"
> + return
> + fi
> +
> case $2 in
> kprobes)
> xbc_get_val ${branch}.probes | while read line; do
> @@ -127,6 +133,13 @@ setup_events() { # prefix("ftrace" or "ftrace.instance.INSTANCE") [instance]
> setup_event $prefix ${grpev%.*} ${grpev#*.} $2
> done
> fi
> + if xbc_has_branch ${1}.event.enable; then
> + if [ "$2" ]; then
> + run_cmd "echo 1 > $TRACEFS/instances/$2/events/enable"
> + else
> + run_cmd "echo 1 > $TRACEFS/events/enable"
> + fi
> + fi
> }
>
> size2kb() { # size[KB|MB]
>

--
Masami Hiramatsu <mhiramat@kernel.org>