Re: [PATCH v5 2/4] arm64: dts: qcom: sc7280: Add PCIe and PHY related nodes

Prasad Malisetty
2021-08-17T08:03:52Z

On 2021-08-11 01:01, Stephen Boyd wrote:
> Quoting Prasad Malisetty (2021-08-09 21:08:34)
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 53a21d0..4500d88 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -1598,6 +1712,18 @@
>> bias-bus-hold;
>> };
>> };
>> +
>> + pcie1_default_state: pcie1-default-state {
>> + clkreq {
>> + pins = "gpio79";
>> + function = "pcie1_clkreqn";
>> + };
>> +
>> + wake-n {
>> + pins = "gpio3";
>> + function = "gpio";
>
> This is function gpio, so presumably board designers could decide to
> change the wake gpio to something else, right? I'd prefer we move
> wake-n
> to the board level (idp) as well. gpio79 looks fine as it is muxed to
> be
> the pcie1_clkreqn function, not gpio, so it seems to be a dedicated pin
> for this purpose.

Sure, I will move it IDP file in next version.