Re: [PATCH v4 5/7] venus: vdec: set work route to fw

Stephen Boyd
2021-08-12T19:20:10Z

Quoting Dikshita Agarwal (2021-08-10 02:47:53)
> diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
> index 198e47e..4e7b9e5 100644
> --- a/drivers/media/platform/qcom/venus/vdec.c
> +++ b/drivers/media/platform/qcom/venus/vdec.c
> @@ -653,6 +653,24 @@ static int vdec_set_properties(struct venus_inst *inst)
> return 0;
> }
>
> +static int vdec_set_work_route(struct venus_inst *inst)
> +{
> + struct hfi_video_work_route wr;
> + u32 ptype;
> + int ret;
> +
> + if(!IS_V6(inst->core))

Please add a space after 'if'

> + return 0;
> +
> + wr.video_work_route = inst->core->res->num_vpp_pipes;
> +
> + ptype = HFI_PROPERTY_PARAM_WORK_ROUTE;
> + ret = hfi_session_set_property(inst, ptype, &wr);
> + if (ret)
> + return ret;
> + return 0;

return hfi_session_set_property(...) is shorter.

> +}
> +
> #define is_ubwc_fmt(fmt) (!!((fmt) & HFI_COLOR_FORMAT_UBWC_BASE))
>
> static int vdec_output_conf(struct venus_inst *inst)