From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755281AbbIWOOa (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Sep 2015 10:14:30 -0400
Received: from xes-mad.com ([216.165.139.218]:13569 "EHLO xes-mad.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755204AbbIWOO3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Sep 2015 10:14:29 -0400
Date: Wed, 23 Sep 2015 09:13:19 -0500 (CDT)
From: Aaron Sierra <asierra@xes-inc.com>
To: Lee Jones <lee.jones@linaro.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
        Peter Tyser <ptyser@xes-inc.com>, Guenter Roeck <linux@roeck-us.net>,
        Jean Delvare <jdelvare@suse.com>, Samuel Ortiz <sameo@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Matt Fleming <matt.fleming@intel.com>
Message-ID: <1629190950.19992.1443017599911.JavaMail.zimbra@xes-inc.com>
In-Reply-To: <20150923003119.GA16510@x1>
References: <1595954137.78926.1441307640528.JavaMail.zimbra@xes-inc.com> <1327948457.231209.1442966664848.JavaMail.zimbra@xes-inc.com> <20150923003119.GA16510@x1>
Subject: Re: [PATCH v2] mfd: lpc_ich: Separate device cells for clarity
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.52.16.65]
X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF40 (Linux)/8.0.6_GA_5922)
Thread-Topic: lpc_ich: Separate device cells for clarity
Thread-Index: AjyXpEXf7dreeoMhJyfAMoTKi6HuSQ==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

----- Original Message -----
> From: "Lee Jones" <lee.jones@linaro.org>
> Sent: Tuesday, September 22, 2015 7:31:19 PM
> 
> On Tue, 22 Sep 2015, Aaron Sierra wrote:
> 
> > The lpc_ich_cells array gives the wrong impression about the
> > relationship between the watchdog and GPIO devices. They are
> > completely distinct devices, so this patch separates the
> > array into distinct mfd_cell structs per device.
> > 
> > A side effect of removing the array, is that the lpc_cells enum
> > is no longer needed.
> > 
> > Signed-off-by: Aaron Sierra <asierra@xes-inc.com>
> > ---
> >  v2 - rebase onto 4.3-rc2
> > 
> >  drivers/mfd/lpc_ich.c | 42 ++++++++++++++++++------------------------
> >  1 file changed, 18 insertions(+), 24 deletions(-)
> 
> Looks like you didn't apply Andy's Ack!

Sorry, Andy! I erred on the side of caution. I wasn't sure if
the Ack applied to the concept or the iteration of the patch.

> Applied with Andy's Ack.

Thanks

-Aaron