From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751445AbdKUS62 (ORCPT ); Tue, 21 Nov 2017 13:58:28 -0500 Received: from vulcan.natalenko.name ([104.207.131.136]:10434 "EHLO vulcan.natalenko.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281AbdKUS61 (ORCPT ); Tue, 21 Nov 2017 13:58:27 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 vulcan.natalenko.name 2953A298B76 Authentication-Results: vulcan.natalenko.name; dmarc=fail (p=none dis=none) header.from=natalenko.name From: Oleksandr Natalenko To: Pali =?ISO-8859-1?Q?Roh=E1r?= Cc: Mario Limonciello , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Garrett , Darren Hart , Andy Shevchenko , Dmitry Torokhov Subject: Re: Dell Vostro 3360 multimedia keys Date: Tue, 21 Nov 2017 19:58:24 +0100 Message-ID: <1629929.m6cr89zbSo@natalenko.name> In-Reply-To: <201711211936.25184@pali> References: <5089742.2pBsoxBtzf@natalenko.name> <1716681.OUoELY8X92@natalenko.name> <201711211936.25184@pali> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=natalenko.name; s=arc-20170712; t=1511290705; h=from:subject:date:message-id:to:cc:mime-version:content-type:content-transfer-encoding:in-reply-to:references; bh=18TT3YtnDELFRioLqtKphnI8xHDKFBWAIk58AgGl75g=; b=TqrXHd0kRy2CMr6yjfROIma3ASRJqISElDb5NR5gGeZBNHRpd5yrouZTTUmhM/caGYP4tU U3CVhIup/0CTsH3hkKB7I1erqIRa9rl7CprzVBXQCaYjKJ+VMEflQeAlU4Ri/AW8WZNUTz hrAN2EUMk2OIJ2j+T2hMsmmAC+muvcE= ARC-Seal: i=1; s=arc-20170712; d=natalenko.name; t=1511290705; a=rsa-sha256; cv=none; b=y3pcUuIYYJ2xrtFKJAJbo9B6HPvCiRqESaWMbjpwXkH78QWExivfmib2NOB/xyNXvG3e1oG/MRg5uW8qKPWlbA3mEFfyBqfw9LkyGZ/6aHIoV84IIz1e+QaKdJ7bPyEUcfK64Qspyd6SzhrC0fPs/gE0i3gSAg/F/kjTgBLzrM0= ARC-Authentication-Results: i=1; auth=pass smtp.auth=oleksandr@natalenko.name smtp.mailfrom=oleksandr@natalenko.name Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vALIwY3R015362 Hi. On úterý 21. listopadu 2017 19:36:24 CET Pali Rohár wrote: > Ok, if wmi_requires_smbios_request is really doing nothing, then it > should not be used. It enables some QSET feature in Dell SMM mode which > is for 2 laptops. It is also used to filter 0xe025 key code which is generated by 3rd key and is visible via both atkbd and wmi: === 343 if (type == 0x0000 && code == 0xe025 && !wmi_requires_smbios_request) 344 return; === (see commit 13f5059ac5a6b) > Looks like that Dell Vostro 3360 have this meaning for multimedia keys: > > first key: Mobility Center > second key: Dell Support Center > third key: Dell Instant Launch Manager > > (same as other Vostro laptops) Likely, yes. At least, for Launch Manager (key "3") there is a record in the table: === 135 /* Dell Instant Launch key */ 136 { KE_KEY, 0xe025, { KEY_PROG4 } }, === As for Mobility Center, relevant key is commented out and has completely different keycode: === 150 /* Untested, Windows Mobility Center button on Inspiron 7520 */ 151 /* { KE_IGNORE, 0xe02a, { KEY_RESERVED } }, */ === For Support Center, it is not commented, but still reserved: === 189 /* Dell Support Center key */ 190 { KE_IGNORE, 0xe06e, { KEY_RESERVED } }, === > But do not know what KEY_* are used on other Vostro laptops for those > keys. It would be great to use same KEY_*... So, according to what I see above, it looks like KEY_PROG(X) pattern should be followed. > > Well, I've tried. The problem is that if I even configure this key > > via setkeycodes, it doesn't work. > > Hm... why it does not work? > > CCing Dmitry, can you tell us what needs to be done to "active" key from > AT Keyboard driver which prints following messages to dmesg? Just to note what I did. Here is my custom /etc/udev/hwdb.d/90-dell- vostro-3360.hwdb: === evdev:atkbd:dmi:bvnDellInc.:bvrA18:bd09/25/2013:svnDellInc.:pnVostro3360:pvr:rvnDellInc.:rn0F5DWF:rvrA00:cvnDellInc.:ct8:cvr0.1: KEYBOARD_KEY_60=prog4 === Here is how this key press is being detected by evtest via atkbd: === Event: time 1511289883.083968, type 4 (EV_MSC), code 4 (MSC_SCAN), value 60 Event: time 1511289883.083968, type 1 (EV_KEY), code 203 (KEY_PROG4), value 2 Event: time 1511289883.083968, -------------- SYN_REPORT ------------ === But xev shows nothing when I press this key. Am I doing something wrong? > In dell-wmi we filter all key events which are also delivered via PS/2 > AT Keyboard driver. So filtering PS/2 keys instead of WMI is anti-design > solution. Well, sounds reasonable... Thanks. Regards, Oleksandr