From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755603AbcAYI4F (ORCPT ); Mon, 25 Jan 2016 03:56:05 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:64536 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbcAYI4D (ORCPT ); Mon, 25 Jan 2016 03:56:03 -0500 From: Arnd Bergmann To: Shawn Lin Cc: Jaehoon Chung , Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt Date: Mon, 25 Jan 2016 09:55:53 +0100 Message-ID: <1630713.rPyRx6D05H@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56A5AAF9.5090002@rock-chips.com> References: <1453684420-1860-1-git-send-email-shawn.lin@rock-chips.com> <56A5A11A.5030103@samsung.com> <56A5AAF9.5090002@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:OHidYfFsVXQpWJHVB88YXYigtcgyqtS3pBvMOussAiTj4RfNEJU GWYZYpiPVzqncfBtFCliFV71KzaXCz3mKb5Ce+NcwAYjphjN+X0fqTXvmGr4pN+hGtJh9lh 10EtYA0DX19F6Tz8Ow9cm5jWZ1QoMMt1Pep1Wfx1j1IORxa3u0uj1ZYaZ094QweY9bN8jGe ryO/RhQ0J1NWsW5gg0Bpw== X-UI-Out-Filterresults: notjunk:1;V01:K0:xTYLL4B7G4Q=:w75xFh6L3TtUjbxQoIWhFy VlHZJG/RP5I/jFxPpCFuPr7STw1T2vMwScNXyvy2I+wGJNhvE4aFUey79NTdn/TI5P+Z1uf7X ximEfdXLqbXEFmx52V7N+JNIWdSgkTDfiiWLJSwESUh+z2vuFDWbhXbf4teO0S4kMZaW22AoQ LkMVsl/mgDl9V8w8rK5nWzk8pXTPgV/GtjA49V9dcGsJ5vSUYVI9fnek8BwIv9f1AtiAYqN85 ygRDIlZAPcigB4bk5hGSuC6uEbgPa/zPf22nLk1Vd3BAzPxXn7xhQON+S4u4Z06DZXeDjNo/E 9Oc/KTxH4w9c7QvuZ96oG5ZzcigkNAkXJr7UGg3ussdhoUq4PGdrFqM8oCDRZ7pRtuMhncqIx XC5imY/mAyVmgGhRHIO9CGj+EIs0zwznngTcisCuxSQIUnZThAjSF9zhOqlKOzxd9+zVkrfXw /fFceYFKAxz++t8kqaUIXIBKQlgNa6pd917mlmn8ppgWSBS7NbLio1/QFh6llrChOUx8Jr7Lx klhOs0bEf+GwX++2vAEIeQknoOKER1PiFPRViK3adoQwtQ/kMTR4TN5ioe2rwoCgi7SipojI8 /P44B9W5adFikvLq0p2HZ0rU20R2DUdjZBYoj/TX5db9NlrM5eQG/UeZnD2lnLJSTL430DQcT KS3nvc7baFbkeSKs1qkZx2DAR4K4m5/+fAJmmHtuEL3EmqPQdTMRenzdH8L6f5MrUqVEZHyJC f1RnfOeHb3952xJM Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 25 January 2016 12:56:25 Shawn Lin wrote: > On 2016/1/25 12:14, Jaehoon Chung wrote: > > Hi, Shawn. > > > > On 01/25/2016 10:13 AM, Shawn Lin wrote: > >> This patch remove repetitive clear interrupt while > >> probing dw_mmc. > > > > Could you explain to me more? > > yes, it's a trivial improvement. > > dw_mci_probe clear interrupt and disable all interrupt firstly. > Then commit 2da1d7f2 add a new clear-interrupt operation before > enable some interrupt. I can't see any reason to clear it twice > here. No any side effect I had found in my test pattern without this > . May I miss some important case? > The explanation should go into the patch description to explain why it is done. The one sentence "This patch remove repetitive clear interrupt while probing dw_mmc" that you wrote instead can be removed, it just repeats the patch subject. Arnd