Re: [PATCH v3 0/6] bootconfig: Cleanup and reorder the init parameter from bootconfig

Masami Hiramatsu
2021-09-08T03:46:25Z

On Sun, 5 Sep 2021 00:54:01 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Hi Steve,
>
> Here is the 3rd version of the patches to update the bootconfig.
> I added 3 patches to fix some issues. One issue is from Julio which
> fixes a compilation error ([5/6]*). And the other 2 are fixing
> ftrace2bconf script ([4/6]) and cleanup test script ([6/6]).
>
> * https://lore.kernel.org/all/20210831033256.5973-1-jcfaracco@gmail.com/T/#u
>
> The 1st one is for bootconfig memory cleanup when exiting init stage.
> The 2nd one and 3rd one are for reordering the init parameters from
> bootconfig.
> Since the current kernel concatenate the kernel cmdline and the
> bootconfig parameters as below.
>
> [bootconfig kernel params][cmdline] -- [init cmdline][bootconfig init params]
>
> This is bit odd because for the kernel parameters, user passed cmdline
> can override the previous (bootconfig) one, but for the init cmdline,
> bootconfig may override the parameter.
> Thus, this series invert the order as the following.
>
> [bootconfig kernel params][cmdline] -- [bootconfig init params][init cmdline]
>
> The 3rd patch is adding how to use the bootconfig for passing kernel
> and init parameters.
>
> Thank you,

Hi Steve,

BTW, this includes Julio's fix patch we discussed in the other thread.
If you picked it, please ignore that patch in this series.

Thank you,

>
> ---
>
> Julio Faracco (1):
> bootconfig: Fix missing return check of xbc_node_compose_key function
>
> Masami Hiramatsu (5):
> init: bootconfig: Remove all bootconfig data when the init memory is removed
> init/bootconfig: Reorder init parameter from bootconfig and cmdline
> docs: bootconfig: Add how to use bootconfig for kernel parameters
> tools/bootconfig: Fix tracing_on option checking in ftrace2bconf.sh
> tools/bootconfig: Show whole test command for each test case
>
>
> Documentation/admin-guide/bootconfig.rst | 39 +++++++++++++++++++++++++++++-
> init/main.c | 37 ++++++++++++++++++++--------
> tools/bootconfig/main.c | 4 ++-
> tools/bootconfig/scripts/ftrace2bconf.sh | 4 ++-
> tools/bootconfig/test-bootconfig.sh | 4 ++-
> 5 files changed, 71 insertions(+), 17 deletions(-)
>
> --
> Masami Hiramatsu (Linaro) <mhiramat@kernel.org>

--
Masami Hiramatsu <mhiramat@kernel.org>