Re: [PATCH 1/4] dt-bindings: devicetree documentation for secure domain

Srinivas Kandagatla
2021-09-29T14:06:35Z

Thanks Jeya,

Subject line should look something like "misc: dt-bindings: fastrpc..."

On 24/09/2021 13:19, Jeya R wrote:
> Add information about secure domain property.
>
> Signed-off-by: Jeya R <jeyr@codeaurora.org>
> ---
> Documentation/devicetree/bindings/misc/qcom,fastrpc.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt b/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
> index 2a1827a..276c1d1 100644
> --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
> +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
> @@ -49,6 +49,12 @@ on the dsp.
> context bank. Defaults to 1 when this property
> is not specified.
>
> +- secure-domains:

Should this not be qcom,secure-domain ??

You have added this binding for compute banks but the driver changes
suggest that it should be for fastrpc.

> + Usage: Optional
> + Value type: <empty>

boolean?

> + Definition: Specify DSP domain is secure, must be
> + "qcom,secure-domain"
May be reword this to "Only applicable for CDSP domains, presence of
this property indicates that domain in secured"

> +
> Example:
>
> adsp-pil {
>