Re: [PATCH 2/3] eCryptfs: export key type

[David Howells <dhowells@redhat.com>]

Michael Halcrow <mhalcrow@us.ibm.com> wrote:

> > +EXPORT_SYMBOL( key_type_user );
> 
> This is the only modification necessary to support eCryptfs.

Unfortunately, that might have to be EXPORT_SYMBOL_GPL() nowadays since I
reimplemented the predefined keyring types of user and keyring using RCU.

> While we are working on getting it ready for merging into the mainline
> kernel, we would like to distribute it as a separate kernel module, and we
> would like for users or distro's do not need to modify their kernels to
> build and run it.

"It" being?

> Would there be any objections to exporting the key_type_user symbol?
> Is there any general reason why kernel modules should not have access
> to the user key type struct?

No and no, but see above. You could also export the user defined key type ops
and define your own key type using them.

David