Re: [PATCH 3/3] pinctrl: qcom: Add SC7280 lpass pin configuration

Stephen Boyd
2021-10-07T17:54:19Z

Quoting Srinivasa Rao Mandadapu (2021-10-07 06:48:39)
> diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
> index c0117c5..0b68065 100644
> --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
> +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
> @@ -237,6 +264,15 @@ static struct lpi_pinctrl_variant_data sm8250_lpi_data = {
> .nfunctions = ARRAY_SIZE(lpass_functions),
> };
>
> +static struct lpi_pinctrl_variant_data sc7280_lpi_data = {

Can this variant data be const?

> + .pins = lpass_lpi_pins,
> + .npins = ARRAY_SIZE(lpass_lpi_pins),
> + .groups = sc7280_groups,
> + .ngroups = ARRAY_SIZE(sc7280_groups),
> + .functions = lpass_functions,
> + .nfunctions = ARRAY_SIZE(lpass_functions),
> +};
> +
> static int lpi_gpio_read(struct lpi_pinctrl *state, unsigned int pin,
> unsigned int addr)
> {