* [PATCH linux-next] ethernet: Remove redundant statement
@ 2021-10-18 8:55 luo penghao
2021-10-19 12:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: luo penghao @ 2021-10-18 8:55 UTC (permalink / raw)
To: Siva Reddy Kallam
Cc: Prashant Sreedharan, Michael Chan, David S . Miller,
Jakub Kicinski, netdev, linux-kernel, luo penghao, Zeal Robot
The variable will be assigned again later in the if condition,
there is no meaning there.
drivers/net/ethernet/broadcom/tg3.c:5750:2 warning:
Value stored to 'current_link_up' is never read.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: luo penghao <luo.penghao@zte.com.cn>
---
drivers/net/ethernet/broadcom/tg3.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index e9518b9..b1328c5 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -5747,7 +5747,6 @@ static int tg3_setup_fiber_phy(struct tg3 *tp, bool force_reset)
tw32_f(MAC_EVENT, MAC_EVENT_LNKSTATE_CHANGED);
udelay(40);
- current_link_up = false;
tp->link_config.rmt_adv = 0;
mac_status = tr32(MAC_STATUS);
--
2.15.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] ethernet: Remove redundant statement
2021-10-18 8:55 [PATCH linux-next] ethernet: Remove redundant statement luo penghao
@ 2021-10-19 12:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-19 12:20 UTC (permalink / raw)
To: Ye Guojin
Cc: siva.kallam, prashant, mchan, davem, kuba, netdev, linux-kernel,
luo.penghao, zealci
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Mon, 18 Oct 2021 08:55:13 +0000 you wrote:
> The variable will be assigned again later in the if condition,
> there is no meaning there.
>
> drivers/net/ethernet/broadcom/tg3.c:5750:2 warning:
>
> Value stored to 'current_link_up' is never read.
>
> [...]
Here is the summary with links:
- [linux-next] ethernet: Remove redundant statement
https://git.kernel.org/netdev/net-next/c/3c71e0c9ab4f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-19 12:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-18 8:55 [PATCH linux-next] ethernet: Remove redundant statement luo penghao
2021-10-19 12:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox