Re: [PATCH 1/3] pinctrl: Add driver for Sunplus SP7021

Randy Dunlap
2021-10-29T04:38:14Z

On 10/28/21 8:40 PM, Wells Lu 呂芳騰 wrote:
> Hi Sir,
>
> Thank you for your review.
>
> I modified errors in Kconfig you pointed out.
>
> Could you please teach me what is the next step I need to do
> (This is my first submission to Linux kernel main-line)?

Hi,

I would wait another day or two to see if there are any other
comments or reviews of the patch series, then send a v2 of
the entire series.

> 1. Should I make a patch [PATHC 1/3 v2] for Kconfig and submit
> again?
> 2. Or wait for other files of the patch [PATCH 1/3] being
> reviewed and then submit patch again.
> 3. At first patch, I used 'git send-email' command to send a
> patch series. The command is:
> git send-email \
> --to linus.walleij@linaro.org \
> --to linux-gpio@vger.kernel.org \
> --to linux-kernel@vger.kernel.org \
> --to robh+dt@kernel.org \
> --to devicetree@vger.kernel.org \
> --cc dvorkin@tibbo.com \
> --cc qinjian@cqplus1.com \
> --thread 000*.patch
> Please teach me what command options of 'git send-email'
> I should use to send the version 2 patch.

I suppose that you are using git to create patches.
I don't create patches with git, so I don't know what it takes to
create and send v2 of a patch series.

If you are not using git to create patches, you can just modify
the Subject: line in each email to include the "v2" string.

In either case, but sure to describe the changes from v1 to v2.
This description goes after (below) the "---" line. I put it before
the diffstat output with a blank line separating them.

> 4. If this is not a correct way to reply your email, please teach
> me how to reply maintainers' email.

This is fine.

thanks.
--
~Randy