* [PATCH net-next] xdp: Remove redundant warning
@ 2021-10-27 1:38 Yajun Deng
2021-10-27 6:20 ` Jesper Dangaard Brouer
2021-10-28 2:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Yajun Deng @ 2021-10-27 1:38 UTC (permalink / raw)
To: ast, daniel, davem, kuba, hawk, john.fastabend
Cc: netdev, bpf, linux-kernel, Yajun Deng
There is a warning in xdp_rxq_info_unreg_mem_model() when reg_state isn't
equal to REG_STATE_REGISTERED, so the warning in xdp_rxq_info_unreg() is
redundant.
Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
---
net/core/xdp.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/core/xdp.c b/net/core/xdp.c
index cc92ccb38432..5ddc29f29bad 100644
--- a/net/core/xdp.c
+++ b/net/core/xdp.c
@@ -143,8 +143,6 @@ void xdp_rxq_info_unreg(struct xdp_rxq_info *xdp_rxq)
if (xdp_rxq->reg_state == REG_STATE_UNUSED)
return;
- WARN(!(xdp_rxq->reg_state == REG_STATE_REGISTERED), "Driver BUG");
-
xdp_rxq_info_unreg_mem_model(xdp_rxq);
xdp_rxq->reg_state = REG_STATE_UNREGISTERED;
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] xdp: Remove redundant warning
2021-10-27 1:38 [PATCH net-next] xdp: Remove redundant warning Yajun Deng
@ 2021-10-27 6:20 ` Jesper Dangaard Brouer
2021-10-28 2:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jesper Dangaard Brouer @ 2021-10-27 6:20 UTC (permalink / raw)
To: Yajun Deng, ast, daniel, davem, kuba, hawk, john.fastabend
Cc: brouer, netdev, bpf, linux-kernel, Björn Töpel
On 27/10/2021 03.38, Yajun Deng wrote:
> There is a warning in xdp_rxq_info_unreg_mem_model() when reg_state isn't
> equal to REG_STATE_REGISTERED, so the warning in xdp_rxq_info_unreg() is
> redundant.
>
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
I guess/wonder if we should mark this as a fix for:
Fixes: dce5bd6140a4 ("xdp: export xdp_rxq_info_unreg_mem_model")
> ---
> net/core/xdp.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/core/xdp.c b/net/core/xdp.c
> index cc92ccb38432..5ddc29f29bad 100644
> --- a/net/core/xdp.c
> +++ b/net/core/xdp.c
> @@ -143,8 +143,6 @@ void xdp_rxq_info_unreg(struct xdp_rxq_info *xdp_rxq)
> if (xdp_rxq->reg_state == REG_STATE_UNUSED)
> return;
>
> - WARN(!(xdp_rxq->reg_state == REG_STATE_REGISTERED), "Driver BUG");
> -
> xdp_rxq_info_unreg_mem_model(xdp_rxq);
>
> xdp_rxq->reg_state = REG_STATE_UNREGISTERED;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] xdp: Remove redundant warning
2021-10-27 1:38 [PATCH net-next] xdp: Remove redundant warning Yajun Deng
2021-10-27 6:20 ` Jesper Dangaard Brouer
@ 2021-10-28 2:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-28 2:00 UTC (permalink / raw)
To: Yajun Deng
Cc: ast, daniel, davem, kuba, hawk, john.fastabend, netdev, bpf,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 27 Oct 2021 09:38:56 +0800 you wrote:
> There is a warning in xdp_rxq_info_unreg_mem_model() when reg_state isn't
> equal to REG_STATE_REGISTERED, so the warning in xdp_rxq_info_unreg() is
> redundant.
>
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> ---
> net/core/xdp.c | 2 --
> 1 file changed, 2 deletions(-)
Here is the summary with links:
- [net-next] xdp: Remove redundant warning
https://git.kernel.org/netdev/net-next/c/b859a360d88d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-28 2:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-27 1:38 [PATCH net-next] xdp: Remove redundant warning Yajun Deng
2021-10-27 6:20 ` Jesper Dangaard Brouer
2021-10-28 2:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox