Re: [PATCH 1/3] pinctrl: Add driver for Sunplus SP7021

Randy Dunlap
2021-10-27T22:12:16Z

Hi--

On 10/27/21 1:55 AM, Wells Lu wrote:
> diff --git a/drivers/pinctrl/sunplus/Kconfig b/drivers/pinctrl/sunplus/Kconfig
> new file mode 100644
> index 0000000..93b5ccf
> --- /dev/null
> +++ b/drivers/pinctrl/sunplus/Kconfig
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Sunplus Pin control driver configuration
> +#
> +
> +config PINCTRL_SPPCTL
> + bool "Sunplus SP7021 pinmux and gpio driver"

Preferably GPIO

> + depends on SOC_SP7021
> + select PINMUX
> + select GENERIC_PINCTRL_GROUPS
> + select CONFIG_GENERIC_PINMUX_FUNCTIONS

Drop CONFIG_

> + select PINCONF
> + select GENERIC_PINCONF
> + select OF_GPIO

Probably
depends on OF && HAS_IOMEM
Otherwise how do you know that it's safe to do
select OF_GPIO
?

> + select GPIOLIB
> + select GPIO_SYSFS
> + select GENERIC_IRQ_CHIP
> + select GPIOLIB_IRQCHIP
> + help
> + Say Y here to support Sunplus SP7021 pinmux controller.
> + The driveer is selected automatically by platform.

driver

> + This driver requires the pinctrl framework.
> + GPIO is provided by the same driver.
> +
> +config PINCTRL_SPPCTL_DEBUG
> + bool "Sunplus pinmux specific debug"
> + depends on SOC_SP7021 && DEBUG_PINCTRL
> + help
> + Say Y if you need to debug Sunplus pinmux driver in-depth.
> + Pin control driver will output more messages if you enable
> + this item. This function is dependent on DEBUG_PINCTRL. It
> + should be enabled first.

thanks.
--
~Randy