* [PATCH] net: ethernet: litex: Remove unnecessary print function dev_err()
@ 2021-11-05 1:42 Xu Wang
2021-11-05 3:15 ` Cai Huoqing
2021-11-05 10:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Xu Wang @ 2021-11-05 1:42 UTC (permalink / raw)
To: joel, caihuoqing; +Cc: netdev, linux-kernel
The print function dev_err() is redundant because
platform_get_irq() already prints an error.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/net/ethernet/litex/litex_liteeth.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c
index 3d9385a4989b..ab9fa1525053 100644
--- a/drivers/net/ethernet/litex/litex_liteeth.c
+++ b/drivers/net/ethernet/litex/litex_liteeth.c
@@ -242,10 +242,8 @@ static int liteeth_probe(struct platform_device *pdev)
priv->dev = &pdev->dev;
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "Failed to get IRQ %d\n", irq);
+ if (irq < 0)
return irq;
- }
netdev->irq = irq;
priv->base = devm_platform_ioremap_resource_byname(pdev, "mac");
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: litex: Remove unnecessary print function dev_err()
2021-11-05 1:42 [PATCH] net: ethernet: litex: Remove unnecessary print function dev_err() Xu Wang
@ 2021-11-05 3:15 ` Cai Huoqing
2021-11-05 10:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Cai Huoqing @ 2021-11-05 3:15 UTC (permalink / raw)
To: Xu Wang; +Cc: joel, netdev, linux-kernel
On 05 11月 21 01:42:17, Xu Wang wrote:
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>
Reviewed-by: Cai Huoqing <caihuoqing@baidu.com>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
> drivers/net/ethernet/litex/litex_liteeth.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c
> index 3d9385a4989b..ab9fa1525053 100644
> --- a/drivers/net/ethernet/litex/litex_liteeth.c
> +++ b/drivers/net/ethernet/litex/litex_liteeth.c
> @@ -242,10 +242,8 @@ static int liteeth_probe(struct platform_device *pdev)
> priv->dev = &pdev->dev;
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(&pdev->dev, "Failed to get IRQ %d\n", irq);
> + if (irq < 0)
> return irq;
> - }
> netdev->irq = irq;
>
> priv->base = devm_platform_ioremap_resource_byname(pdev, "mac");
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: litex: Remove unnecessary print function dev_err()
2021-11-05 1:42 [PATCH] net: ethernet: litex: Remove unnecessary print function dev_err() Xu Wang
2021-11-05 3:15 ` Cai Huoqing
@ 2021-11-05 10:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-05 10:20 UTC (permalink / raw)
To: Xu Wang; +Cc: joel, caihuoqing, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 5 Nov 2021 01:42:17 +0000 you wrote:
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
> drivers/net/ethernet/litex/litex_liteeth.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Here is the summary with links:
- net: ethernet: litex: Remove unnecessary print function dev_err()
https://git.kernel.org/netdev/net/c/827beb7781d3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-05 10:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-05 1:42 [PATCH] net: ethernet: litex: Remove unnecessary print function dev_err() Xu Wang
2021-11-05 3:15 ` Cai Huoqing
2021-11-05 10:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox