From: Rob Herring <robh@kernel.org>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH v2 7/7] dt-bindings: arm64: dts: mediatek: Add sku22 for mt8183 kakadu board
Date: Tue, 09 Nov 2021 07:03:40 -0600 [thread overview]
Message-ID: <1636463020.563453.1726440.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20211109053334.1840273-7-hsinyi@chromium.org>
On Tue, 09 Nov 2021 13:33:34 +0800, Hsin-Yi Wang wrote:
> Add sku22 which uses different audio codec than previous kakadu board.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> v2: fix compatible items matching
> ---
> Documentation/devicetree/bindings/arm/mediatek.yaml | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/mediatek.yaml: properties:compatible:oneOf:27:items: 'oneOf' conditional failed, one must be fixed:
[{'oneOf': [{'items': [{'const': 'google,kakadu-rev3-sku22'}, {'const': 'google,kakadu-rev2-sku22'}]}, {'items': [{'const': 'google,kakadu-rev3'}, {'const': 'google,kakadu-rev2'}]}]}, {'const': 'google,kakadu'}, {'const': 'mediatek,mt8183'}] is not of type 'object'
Additional properties are not allowed ('oneOf' was unexpected)
from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/mediatek.yaml: ignoring, error in schema: properties: compatible: oneOf: 27: items
warning: no schema found in file: ./Documentation/devicetree/bindings/arm/mediatek.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1552630
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
prev parent reply other threads:[~2021-11-09 13:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 5:33 [PATCH v2 1/7] arm64: dts: mt8183: jacuzzi: remove unused ddc-i2c-bus Hsin-Yi Wang
2021-11-09 5:33 ` [PATCH v2 2/7] arm64: dts: mt8183: Add kukui-jacuzzi-cozmo board Hsin-Yi Wang
2021-11-09 5:33 ` [PATCH v2 3/7] arm64: dts: mt8183: Add more fennel SKUs Hsin-Yi Wang
2021-11-09 5:33 ` [PATCH v2 4/7] arm64: dts: mt8183: Add kakadu sku22 Hsin-Yi Wang
2021-11-09 5:33 ` [PATCH v2 5/7] dt-bindings: arm64: dts: mediatek: Add mt8183-kukui-jacuzzi-cozmo Hsin-Yi Wang
2021-11-09 5:33 ` [PATCH v2 6/7] dt-bindings: arm64: dts: mediatek: Add more SKUs for mt8183 fennel board Hsin-Yi Wang
2021-11-09 5:33 ` [PATCH v2 7/7] dt-bindings: arm64: dts: mediatek: Add sku22 for mt8183 kakadu board Hsin-Yi Wang
2021-11-09 13:03 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1636463020.563453.1726440.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox