public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] asus-wmi: remove unneeded semicolon
@ 2021-11-24  2:02 Yang Li
  2021-11-25 15:36 ` Hans de Goede
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-11-24  2:02 UTC (permalink / raw)
  To: corentin.chary
  Cc: hdegoede, markgross, acpi4asus-user, platform-driver-x86,
	linux-kernel, Yang Li

Eliminate the following coccicheck warning:
./drivers/platform/x86/asus-wmi.c:2386:2-3: Unneeded semicolon

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/platform/x86/asus-wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index ab0c087..6fa4b0b 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -2383,7 +2383,7 @@ static ssize_t fan_curve_enable_store(struct device *dev,
 		break;
 	default:
 		return -EINVAL;
-	};
+	}
 
 	if (data->enabled) {
 		err = fan_curve_write(asus, data);
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] asus-wmi: remove unneeded semicolon
  2021-11-24  2:02 [PATCH -next] asus-wmi: remove unneeded semicolon Yang Li
@ 2021-11-25 15:36 ` Hans de Goede
  0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-11-25 15:36 UTC (permalink / raw)
  To: Yang Li, corentin.chary
  Cc: markgross, acpi4asus-user, platform-driver-x86, linux-kernel

Hi,

On 11/24/21 03:02, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/platform/x86/asus-wmi.c:2386:2-3: Unneeded semicolon
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/x86/asus-wmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index ab0c087..6fa4b0b 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -2383,7 +2383,7 @@ static ssize_t fan_curve_enable_store(struct device *dev,
>  		break;
>  	default:
>  		return -EINVAL;
> -	};
> +	}
>  
>  	if (data->enabled) {
>  		err = fan_curve_write(asus, data);
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-25 15:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-24  2:02 [PATCH -next] asus-wmi: remove unneeded semicolon Yang Li
2021-11-25 15:36 ` Hans de Goede

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox