Re: [PATCH v3 13/15] dt-bindings: ata: Convert Broadcom SATA to YAML

Rob Herring
2021-12-14T18:29:01Z

On Wed, Dec 08, 2021 at 09:33:38AM -0800, Florian Fainelli wrote:
> On 12/8/21 5:44 AM, Rob Herring wrote:
> > On Tue, 07 Dec 2021 16:37:24 -0800, Florian Fainelli wrote:
> >> Convert the Broadcom SATA3 AHCI controller Device Tree binding to YAML
> >> to help with validation.
> >>
> >> Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> >> ---
> >> .../bindings/ata/brcm,sata-brcm.txt | 45 ---------
> >> .../bindings/ata/brcm,sata-brcm.yaml | 98 +++++++++++++++++++
> >> 2 files changed, 98 insertions(+), 45 deletions(-)
> >> delete mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt
> >> create mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
> >>
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
> > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > This will change in the future.
> >
> > Full log is available here: https://patchwork.ozlabs.org/patch/1565011
>
> Likewise, those indicate that the preceding patch which renames the sata
> controller unit name has not been applied.

I looked at that, but it was the unevaluated properties I was worried
about. However, the example has the same thing, but no errors. I think
running with DT_SCHEMA_FILES means sata-common.yaml is not included.
I'll have to look into that.

Rob