* [PATCH] nfc: fix potential NULL pointer deref in nfc_genl_dump_ses_done
@ 2021-12-09 8:13 Krzysztof Kozlowski
2021-12-09 16:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-12-09 8:13 UTC (permalink / raw)
To: Krzysztof Kozlowski, David S. Miller, Jakub Kicinski,
Samuel Ortiz, linux-nfc, netdev, linux-kernel
Cc: tadeusz.struk, stable
The done() netlink callback nfc_genl_dump_ses_done() should check if
received argument is non-NULL, because its allocation could fail earlier
in dumpit() (nfc_genl_dump_ses()).
Fixes: ac22ac466a65 ("NFC: Add a GET_SE netlink API")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
net/nfc/netlink.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c
index 334f63c9529e..5c706ed75b33 100644
--- a/net/nfc/netlink.c
+++ b/net/nfc/netlink.c
@@ -1392,8 +1392,10 @@ static int nfc_genl_dump_ses_done(struct netlink_callback *cb)
{
struct class_dev_iter *iter = (struct class_dev_iter *) cb->args[0];
- nfc_device_iter_exit(iter);
- kfree(iter);
+ if (iter) {
+ nfc_device_iter_exit(iter);
+ kfree(iter);
+ }
return 0;
}
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfc: fix potential NULL pointer deref in nfc_genl_dump_ses_done
2021-12-09 8:13 [PATCH] nfc: fix potential NULL pointer deref in nfc_genl_dump_ses_done Krzysztof Kozlowski
@ 2021-12-09 16:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-09 16:00 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: davem, kuba, sameo, linux-nfc, netdev, linux-kernel,
tadeusz.struk, stable
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 9 Dec 2021 09:13:07 +0100 you wrote:
> The done() netlink callback nfc_genl_dump_ses_done() should check if
> received argument is non-NULL, because its allocation could fail earlier
> in dumpit() (nfc_genl_dump_ses()).
>
> Fixes: ac22ac466a65 ("NFC: Add a GET_SE netlink API")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> [...]
Here is the summary with links:
- nfc: fix potential NULL pointer deref in nfc_genl_dump_ses_done
https://git.kernel.org/netdev/net/c/fd79a0cbf0b2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-09 16:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-09 8:13 [PATCH] nfc: fix potential NULL pointer deref in nfc_genl_dump_ses_done Krzysztof Kozlowski
2021-12-09 16:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox