Re: [PATCH wq/for-3.14 2/2] workqueue: implement @drain for workqueue_set_max_active()

Tejun Heo
2013-12-20T14:23:39Z

On Fri, Dec 20, 2013 at 02:56:09PM +0100, Rafael J. Wysocki wrote:
> On Friday, December 20, 2013 08:32:20 AM Tejun Heo wrote:
> > Hello, Rafael.
> >
> > On Fri, Dec 20, 2013 at 02:31:37AM +0100, Rafael J. Wysocki wrote:
> > > > If this looks good to you, I'll commit it to wq/for-3.14 and we can at
> > > > least start to clean up things.
> > >
> > > Yes, it does.
> > >
> > > So with that I need to do workqueue_set_max_active(wq, WQ_FROZEN_ACTIVE) during
> > > suspend and then workqueue_set_max_active(wq, WQ_DFL_ACTIVE) during resume on
> > > my workqueue, right?
> >
> > Yeah, you can also do workqueue_set_max_active(wq, 0) during resume to
> > restore the default value, which is what's used by alloc_workqueue()
> > anyway.

Oops, it sould be obvious but just in case. The call to use during
suspend is workqueue_set_max_active(wq, WQ_FROZEN_ACTIVE, true). :)

--
tejun