From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757204AbaGQLvQ (ORCPT ); Thu, 17 Jul 2014 07:51:16 -0400 Received: from perceval.ideasonboard.com ([95.142.166.194]:36348 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754855AbaGQLvN convert rfc822-to-8bit (ORCPT ); Thu, 17 Jul 2014 07:51:13 -0400 From: Laurent Pinchart To: Salva =?ISO-8859-1?Q?Peir=F3?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@kernel.org Subject: Re: [PATCH] media-device: Remove duplicated memset() in media_enum_entities() Date: Thu, 17 Jul 2014 13:51:20 +0200 Message-ID: <1640168.vYZHkKuLz0@avalon> User-Agent: KMail/4.11.5 (Linux/3.12.21-gentoo-r1; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1402152104-16865-1-git-send-email-speiro@ai2.upv.es> References: <1402152104-16865-1-git-send-email-speiro@ai2.upv.es> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Salva, Thank you for the patch. On Saturday 07 June 2014 16:41:44 Salva Peiró wrote: > After the zeroing the whole struct struct media_entity_desc u_ent, > it is no longer necessary to memset(0) its u_ent.name field. > > Signed-off-by: Salva Peiró > > To: Mauro Carvalho Chehab > CC: linux-media@vger.kernel.org > CC: linux-kernel@vger.kernel.org > CC: linux-kernel@vger.kernel.org > CC: stable@kernel.org Acked-by: Laurent Pinchart and applied to my tree. > --- > drivers/media/media-device.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c > index 703560f..88c1606 100644 > --- a/drivers/media/media-device.c > +++ b/drivers/media/media-device.c > @@ -106,8 +106,6 @@ static long media_device_enum_entities(struct > media_device *mdev, if (ent->name) { > strncpy(u_ent.name, ent->name, sizeof(u_ent.name)); > u_ent.name[sizeof(u_ent.name) - 1] = '\0'; > - } else { > - memset(u_ent.name, 0, sizeof(u_ent.name)); > } > u_ent.type = ent->type; > u_ent.revision = ent->revision; -- Regards, Laurent Pinchart