From: Richard Weinberger <richard@nod.at>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
Stephan Wurm <stephan.wurm@a-eberle.de>,
stable <stable@vger.kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Oliver Neukum <oliver@neukum.org>, Ali Akcaagac <aliakc@web.de>,
Jamie Lenehan <lenehan@twibble.org>,
James Bottomley <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/7] ubi: block: Refactor sg list processing for highmem
Date: Thu, 10 Aug 2023 21:54:46 +0200 (CEST) [thread overview]
Message-ID: <164102534.5258032.1691697286622.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <ZNUOjQVivR/5pFKE@infradead.org>
----- Ursprüngliche Mail -----
> Von: "Christoph Hellwig" <hch@infradead.org>
> An: "richard" <richard@nod.at>
> On Thu, Aug 10, 2023 at 06:15:36PM +0200, Richard Weinberger wrote:
>> >> The followup patches in this series will switch to kmap_sg()
>> >> and we can remove our own helper and the bounce buffer.
>> >
>> > Please just use kmap_local and avoid the bounce buffering.
>>
>> Patch 6 does this.
>
> But why add the bounce buffering first if you can avoid it from the
> very beginning by just using kmap_local instead of adding a new
> caller for the deprecate kmap_atomic?
Because I want this fix also in all stable trees. kmap_local() is rather
new. When back porting patch 1/7, bounce buffers and kmap_atomic()
are needed anyway.
By doing this in patch 1/7 I avoid backport troubles and keep the
delta between upstream and stable trees minimal.
Thanks,
//richard
next prev parent reply other threads:[~2023-08-10 19:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 16:00 [PATCH 0/7] Fix UBI Block wrt. highmem Richard Weinberger
2023-08-10 16:00 ` [PATCH 1/7] ubi: block: Refactor sg list processing for highmem Richard Weinberger
2023-08-10 16:06 ` Christoph Hellwig
2023-08-10 16:15 ` Richard Weinberger
2023-08-10 16:21 ` Christoph Hellwig
2023-08-10 19:54 ` Richard Weinberger [this message]
2023-08-11 8:12 ` Christoph Hellwig
2023-08-11 8:34 ` Richard Weinberger
2023-08-11 8:36 ` Christoph Hellwig
2023-08-10 16:00 ` [PATCH 2/7] scatterlist: Add kmap helpers Richard Weinberger
2023-08-10 16:00 ` [PATCH 3/7] scsi: dc395x: Switch to kmap_sg Richard Weinberger
2023-08-10 16:00 ` [PATCH 4/7] scsi: esp_scsi: " Richard Weinberger
2023-08-10 16:00 ` [PATCH 5/7] scsi: fdomain: " Richard Weinberger
2023-08-10 16:00 ` [PATCH 6/7] ubi: block: " Richard Weinberger
2023-08-10 16:00 ` [PATCH 7/7] scsi: core: Remove scsi_kmap_atomic_sg() Richard Weinberger
2023-08-11 5:52 ` [PATCH 0/7] Fix UBI Block wrt. highmem Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164102534.5258032.1691697286622.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=aliakc@web.de \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hch@infradead.org \
--cc=jejb@linux.ibm.com \
--cc=lenehan@twibble.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=miquel.raynal@bootlin.com \
--cc=oliver@neukum.org \
--cc=stable@vger.kernel.org \
--cc=stephan.wurm@a-eberle.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox