From: Rob Herring <robh@kernel.org>
To: Yifeng Zhao <yifeng.zhao@rock-chips.com>
Cc: heiko@sntech.de, vkoul@kernel.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
lee.jones@linaro.org, cl@rock-chips.com, kishon@ti.com,
kever.yang@rock-chips.com, linux-arm-kernel@lists.infradead.org,
david.wu@rock-chips.com, michael.riesch@wolfvision.net,
linux-phy@lists.infradead.org, wulf@rock-chips.com,
p.zabel@pengutronix.de, jbx6244@gmail.com
Subject: Re: [PATCH v8 2/4] dt-bindings: phy: rockchip: Add Naneng combo PHY bindings
Date: Tue, 08 Feb 2022 14:33:32 -0600 [thread overview]
Message-ID: <1644352412.075016.2969144.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220208091326.12495-3-yifeng.zhao@rock-chips.com>
On Tue, 08 Feb 2022 17:13:24 +0800, Yifeng Zhao wrote:
> Add the compatible strings for the Naneng combo PHY found on rockchip SoC.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>
> Changes in v8: None
> Changes in v7:
> - remove u3otg0_port_en, u3otg1_port_en and pipe_sgmii_mac_sel
>
> Changes in v5:
> - modify description for ssc and ext-refclk
> - remove apb reset
>
> Changes in v4:
> - restyle
> - remove some minItems
> - add more properties
> - remove reset-names
> - move #phy-cells
> - add rockchip,rk3568-pipe-grf
> - add rockchip,rk3568-pipe-phy-grf
>
> Changes in v3: None
> Changes in v2:
> - Fix dtschema/dtc warnings/errors
>
> .../phy/phy-rockchip-naneng-combphy.yaml | 109 ++++++++++++++++++
> 1 file changed, 109 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml:0:0: /example-0/syscon@fdc50000: failed to match any schema with compatible: ['rockchip,rk3568-pipe-grf', 'syscon']
Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml:0:0: /example-0/syscon@fdc70000: failed to match any schema with compatible: ['rockchip,rk3568-pipe-phy-grf', 'syscon']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1589719
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-02-08 22:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 9:13 [PATCH v8 0/4] Add Naneng combo PHY support for RK3568 Yifeng Zhao
2022-02-08 9:13 ` [PATCH v8 1/4] dt-bindings: soc: grf: add naneng combo phy register compatible Yifeng Zhao
2022-02-08 9:13 ` [PATCH v8 2/4] dt-bindings: phy: rockchip: Add Naneng combo PHY bindings Yifeng Zhao
2022-02-08 20:33 ` Rob Herring [this message]
[not found] ` <2022020911371529703712@rock-chips.com>
2022-02-09 9:14 ` Heiko Stübner
2022-02-28 19:17 ` Rob Herring
2022-02-28 21:36 ` Peter Geis
2022-03-01 14:06 ` Rob Herring
2022-03-02 8:16 ` Vinod Koul
2022-02-08 9:13 ` [PATCH v8 3/4] phy: rockchip: add naneng combo phy for RK3568 Yifeng Zhao
2022-02-08 17:40 ` Peter Geis
2022-02-08 9:13 ` [PATCH v8 4/4] arm64: dts: rockchip: add naneng combo phy nodes for rk3568 Yifeng Zhao
2022-02-09 20:16 ` Aw: " Frank Wunderlich
2022-02-09 16:39 ` Aw: [PATCH v8 0/4] Add Naneng combo PHY support for RK3568 Frank Wunderlich
2022-02-24 14:44 ` Vinod Koul
2022-02-25 16:05 ` (subset) " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1644352412.075016.2969144.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=cl@rock-chips.com \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=kever.yang@rock-chips.com \
--cc=kishon@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=wulf@rock-chips.com \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox