Re: [PATCH] net: dsa: lan9303: fix reset on probe

Måns Rullgård
2022-02-10T13:48:33Z

Jakub Kicinski <kuba@kernel.org> writes:

> On Wed, 9 Feb 2022 14:54:54 +0000 Mans Rullgard wrote:
>> The reset input to the LAN9303 chip is active low, and devicetree
>> gpio handles reflect this. Therefore, the gpio should be requested
>> with an initial state of high in order for the reset signal to be
>> asserted. Other uses of the gpio already use the correct polarity.
>>
>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>
> Pending Andrew's review, this is the correct fixes tag, right?
>
> Fixes: a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303")

Yes, the error has been there since the driver was first added.

--
Måns Rullgård