* [PATCH] net: fix documentation for kernel_getsockname
@ 2022-02-12 10:29 Alex Maydanik
2022-02-14 14:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Alex Maydanik @ 2022-02-12 10:29 UTC (permalink / raw)
Cc: alexander.maydanik, David S. Miller, Jakub Kicinski,
open list:NETWORKING [GENERAL], open list
Fixes return value documentation of kernel_getsockname()
and kernel_getpeername() functions.
The previous documentation wrongly specified that the return
value is 0 in case of success, however sock->ops->getname returns
the length of the address in bytes in case of success.
Signed-off-by: Alex Maydanik <alexander.maydanik@gmail.com>
---
net/socket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/socket.c b/net/socket.c
index 50cf75730fd7..982eecad464c 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -3448,7 +3448,7 @@ EXPORT_SYMBOL(kernel_connect);
* @addr: address holder
*
* Fills the @addr pointer with the address which the socket is bound.
- * Returns 0 or an error code.
+ * Returns the length of the address in bytes or an error code.
*/
int kernel_getsockname(struct socket *sock, struct sockaddr *addr)
@@ -3463,7 +3463,7 @@ EXPORT_SYMBOL(kernel_getsockname);
* @addr: address holder
*
* Fills the @addr pointer with the address which the socket is connected.
- * Returns 0 or an error code.
+ * Returns the length of the address in bytes or an error code.
*/
int kernel_getpeername(struct socket *sock, struct sockaddr *addr)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: fix documentation for kernel_getsockname
2022-02-12 10:29 [PATCH] net: fix documentation for kernel_getsockname Alex Maydanik
@ 2022-02-14 14:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-02-14 14:10 UTC (permalink / raw)
To: Alex Maydanik; +Cc: davem, kuba, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Sat, 12 Feb 2022 12:29:27 +0200 you wrote:
> Fixes return value documentation of kernel_getsockname()
> and kernel_getpeername() functions.
>
> The previous documentation wrongly specified that the return
> value is 0 in case of success, however sock->ops->getname returns
> the length of the address in bytes in case of success.
>
> [...]
Here is the summary with links:
- net: fix documentation for kernel_getsockname
https://git.kernel.org/netdev/net/c/0fc95dec096c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-14 14:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-12 10:29 [PATCH] net: fix documentation for kernel_getsockname Alex Maydanik
2022-02-14 14:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox