From: Rob Herring <robh@kernel.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael Trimarchi <michael@amarulasolutions.com>,
Rob Herring <robh+dt@kernel.org>,
Stephan Gerhold <stephan@gerhold.net>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: input: touchscreen: edt-ft5x06: add report-rate
Date: Tue, 15 Feb 2022 09:22:45 -0600 [thread overview]
Message-ID: <1644938565.059972.3450859.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220213171532.346270-2-dario.binacchi@amarulasolutions.com>
On Sun, 13 Feb 2022 18:15:27 +0100, Dario Binacchi wrote:
> It allows to change the M06/M12 default scan rate.
>
> Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
> .../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml:90:21: [error] syntax error: mapping values are not allowed here (syntax)
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml: mapping values are not allowed in this context
in "<unicode string>", line 90, column 21
make[1]: *** Deleting file 'Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.example.dts'
Traceback (most recent call last):
File "/usr/local/bin/dt-extract-example", line 46, in <module>
binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 434, in load
return constructor.get_single_data()
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 119, in get_single_data
node = self.composer.get_single_node()
File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 891, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
ruamel.yaml.scanner.ScannerError: mapping values are not allowed in this context
in "<unicode string>", line 90, column 21
make[1]: *** [Documentation/devicetree/bindings/Makefile:25: Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml: ignoring, error parsing file
make: *** [Makefile:1398: dt_binding_check] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1592123
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-02-15 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 17:15 [PATCH 0/6] Input: edt-ft5x06 - Improve configuration Dario Binacchi
2022-02-13 17:15 ` [PATCH 1/6] dt-bindings: input: touchscreen: edt-ft5x06: add report-rate Dario Binacchi
2022-02-15 15:22 ` Rob Herring [this message]
2022-02-13 17:15 ` [PATCH 2/6] Input: edt-ft5x06 - get/set M12 report rate by sysfs Dario Binacchi
2022-02-13 17:15 ` [PATCH 3/6] Input: edt-ft5x06 - set report rate by dts property Dario Binacchi
2022-02-13 17:15 ` [PATCH 4/6] Input: edt-ft5x06 - show model name by sysfs Dario Binacchi
2022-02-14 13:02 ` Oliver Graute
2022-02-13 17:15 ` [PATCH 5/6] Input: edt-ft5x06 - show firmware version " Dario Binacchi
2022-02-14 13:02 ` Oliver Graute
2022-02-13 17:15 ` [PATCH 6/6] Input: edt-ft5x06 - show crc and header errors " Dario Binacchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1644938565.059972.3450859.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox