From: Rob Herring <robh@kernel.org>
To: chegbeli <ciprian.hegbeli@analog.com>
Cc: devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
robh+dt@kernel.org, linux-kernel@vger.kernel.org,
jic23@kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: iio: add ADE9078
Date: Sun, 20 Feb 2022 20:36:09 -0600 [thread overview]
Message-ID: <1645410969.316145.2041533.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220217135140.5658-3-ciprian.hegbeli@analog.com>
On Thu, 17 Feb 2022 15:51:39 +0200, chegbeli wrote:
> Added device tree bindings for the ADE9078
>
> Signed-off-by: chegbeli <ciprian.hegbeli@analog.com>
> ---
> .../bindings/iio/meter/adi,ade9078.yaml | 153 ++++++++++++++++++
> include/dt-bindings/iio/meter/adi,ade9078.h | 21 +++
> 2 files changed, 174 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/meter/adi,ade9078.yaml
> create mode 100644 include/dt-bindings/iio/meter/adi,ade9078.h
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/iio/meter/adi,ade9078.yaml:131:1: [error] syntax error: found character '\t' that cannot start any token (syntax)
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/iio/meter/adi,ade9078.yaml: while scanning a block scalar
in "<unicode string>", line 129, column 5
found a tab character where an indentation space is expected
in "<unicode string>", line 131, column 1
make[1]: *** Deleting file 'Documentation/devicetree/bindings/iio/meter/adi,ade9078.example.dts'
Traceback (most recent call last):
File "/usr/local/bin/dt-extract-example", line 46, in <module>
binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 434, in load
return constructor.get_single_data()
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 119, in get_single_data
node = self.composer.get_single_node()
File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 773, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 848, in _ruamel_yaml.CParser._compose_sequence_node
File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
ruamel.yaml.scanner.ScannerError: while scanning a block scalar
in "<unicode string>", line 129, column 5
found a tab character where an indentation space is expected
in "<unicode string>", line 131, column 1
make[1]: *** [Documentation/devicetree/bindings/Makefile:25: Documentation/devicetree/bindings/iio/meter/adi,ade9078.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/meter/adi,ade9078.yaml: ignoring, error parsing file
make: *** [Makefile:1398: dt_binding_check] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1594257
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-02-21 2:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 13:51 [PATCH 0/3] Add ADE9078 Driver chegbeli
2022-02-17 13:51 ` [PATCH 1/3] iio: add meter subdirectory chegbeli
2022-02-17 15:33 ` Krzysztof Kozlowski
2022-02-17 18:34 ` Jonathan Cameron
2022-02-17 13:51 ` [PATCH 2/3] dt-bindings: iio: add ADE9078 chegbeli
2022-02-17 15:44 ` Krzysztof Kozlowski
2022-02-21 2:36 ` Rob Herring [this message]
2022-02-17 13:51 ` [PATCH 3/3] iio: meter: add ADE9078 driver chegbeli
2022-02-17 18:33 ` Jonathan Cameron
2022-04-07 12:56 ` Hegbeli, Ciprian
2022-04-10 15:42 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1645410969.316145.2041533.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=ciprian.hegbeli@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox