Re: [PATCH 2/3] powerpc: fix build errors

Nicholas Piggin
2022-02-24T05:05:38Z

Excerpts from Nicholas Piggin's message of February 24, 2022 12:54 pm:
> Excerpts from Anders Roxell's message of February 23, 2022 11:58 pm:
>> Building tinyconfig with gcc (Debian 11.2.0-16) and assembler (Debian
>> 2.37.90.20220207) the following build error shows up:
>>
>> {standard input}: Assembler messages:
>> {standard input}:1190: Error: unrecognized opcode: `stbcix'
>> {standard input}:1433: Error: unrecognized opcode: `lwzcix'
>> {standard input}:1453: Error: unrecognized opcode: `stbcix'
>> {standard input}:1460: Error: unrecognized opcode: `stwcix'
>> {standard input}:1596: Error: unrecognized opcode: `stbcix'
>> ...
>>
>> Rework to add assembler directives [1] around the instruction. Going
>> through the them one by one shows that the changes should be safe. Like
>> __get_user_atomic_128_aligned() is only called in p9_hmi_special_emu(),
>> which according to the name is specific to power9. And __raw_rm_read*()
>> are only called in things that are powernv or book3s_hv specific.
>>
>> [1] https://sourceware.org/binutils/docs/as/PowerPC_002dPseudo.html#PowerPC_002dPseudo
>
> Thanks for doing this. There is a recent patch committed to binutils to work
> around this compiler bug.
>
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=cebc89b9328
>
> Not sure on the outlook for GCC fix. Either way unfortunately we have
> toolchains in the wild now that will explode, so we might have to take
> your patches for the time being.

Perhaps not... Here's a hack that seems to work around the problem.

The issue of removing -many from the kernel and replacing it with
appropriate architecture versions is an orthogonal one (that we
should do). Either way this hack should be able to allow us to do
that as well, on these problem toolchains.

But for now it just uses -many as the trivial regression fix to get
back to previous behaviour.

Thanks,
Nick

---
arch/powerpc/include/asm/asm-compat.h | 28 +++++++++++++++++++++++++++
1 file changed, 28 insertions(+)

diff --git a/arch/powerpc/include/asm/asm-compat.h b/arch/powerpc/include/asm/asm-compat.h
index 2b736d9fbb1b..f9ac4a36f026 100644
--- a/arch/powerpc/include/asm/asm-compat.h
+++ b/arch/powerpc/include/asm/asm-compat.h
@@ -5,6 +5,34 @@
#include <asm/types.h>
#include <asm/ppc-opcode.h>

+#ifndef __ASSEMBLY__
+/*
+ * gcc 10 started to emit a .machine directive at the beginning of generated
+ * .s files, which overrides assembler -Wa,-m<cpu> options passed down.
+ * Unclear if this behaviour will be reverted.
+ *
+ * gas 2.38 commit b25f942e18d6 made .machine directive more strict, commit
+ * cebc89b9328ea weakens it to take into account the gcc directive and allow
+ * assembler -m<cpu> options to work.
+ *
+ * A combination of both results in an older machine -mcpu= code generation
+ * preventing newer mneumonics in inline asm being recognised because it
+ * overrides our -Wa,-many option from being recognised.
+ *
+ * Emitting a .machine any directive by hand allows us to hack our way around
+ * this.
+ *
+ * XXX: verify versions and combinations.
+ */
+#ifdef CONFIG_CC_IS_GCC
+#if (GCC_VERSION >= 100000)
+#if (CONFIG_AS_VERSION == 23800)
+asm(".machine any");
+#endif
+#endif
+#endif
+#endif /* __ASSEMBLY__ */
+
#ifdef __powerpc64__

/* operations for longs and pointers */
--
2.23.0