Re: [PATCH v4 14/15] perf report: use srcline from callchain for hist entries

Milian Wolff
2017-10-09T20:21:35Z

On Donnerstag, 5. Oktober 2017 06:08:29 CEST Namhyung Kim wrote:
> On Sun, Oct 01, 2017 at 04:30:59PM +0200, Milian Wolff wrote:
> > This also removes the symbol name from the srcline column,
> > more on this below.
> >
> > This ensures we use the correct srcline, which could originate
> > from a potentially inlined function. The hist entries used to
> > query for the srcline based purely on the IP, which leads to
> > wrong results for inlined entries.
>
> Yep, AFAICS current srcline returns the first entry in a inline-chain
> and the srcfile (sort key) returns the last. I think we need to make
> it consistent. It seems this patch fix it when --inline option is
> used, but I guess the --no-inline case still has the problem.

I'm not sure I've understood you correctly. There is indeed an issue still
when passing --no-inline, which seems to arise from the use of
map__rip_2objdump instead of map__objdump_2mem. I've changed that now and will
include that patch in v5 of this patch series.

Cheers

--
Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts