Re: [PATCH v2 1/2] usb: host: ehci-sunplus: Add driver for ehci in Sunplus SP7021

Alan Stern
2022-02-27T16:07:53Z

On Sun, Feb 27, 2022 at 05:50:40PM +0800, Vincent Shih wrote:
> Add driver for ehci in Sunplus SP7021
>
> Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com>
> ---

> +static struct usb_ehci_pdata usb_ehci_pdata = {
> +};
> +
> +static int ehci_sunplus_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct sp_ehci_priv *sp_priv;
> + struct resource *res_mem;
> + struct usb_hcd *hcd;
> + int irq, ret;
> +
> + if (usb_disabled())
> + return -ENODEV;
> +
> + pdev->dev.platform_data = &usb_ehci_pdata;

What reason is there for doing this? I can't see any justification for
storing a pointer to data that contains nothing but zeros.

Alan Stern