From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752135AbbFZHqM (ORCPT ); Fri, 26 Jun 2015 03:46:12 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:37392 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751828AbbFZHqG (ORCPT ); Fri, 26 Jun 2015 03:46:06 -0400 X-AuditID: cbfee691-f79ca6d00000456a-89-558d03397cf9 Date: Fri, 26 Jun 2015 07:46:01 +0000 (GMT) From: Vivek Kumar Bhagat Subject: [EDT][PATCH] XHCI: Fix memory leak in error condition To: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Reply-to: vivek.bhagat@samsung.com MIME-version: 1.0 X-MTR: 20150626073652650@vivek.bhagat Msgkey: 20150626073652650@vivek.bhagat X-EPLocale: en_US.utf-8 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20150626073652650@vivek.bhagat X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=utf-8 MIME-version: 1.0 Message-id: <1646270916.306041435304760891.JavaMail.weblogic@ep2mlwas07b> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAIsWRmVeSWpSXmKPExsWyRsSkSteKuTfU4OQXVovLu+awOTB6fN4k F8AYxWWTkpqTWZZapG+XwJXx99kd9oJdbBXtcxewNDAuYOti5OQQElCXuLL5DDuILSFgIjF1 934mCFtM4sK99UA1XEA1SxklPl84ywRTtHXtc3aI5jmMEufuB4HYLAKqEgdu/ASLswHVvDq0 kxXEFhawk1hw9DRLFyMHh4hAlsTjg+YQrUoSny/tASvhFRCUODnzCViJBNCYPYtzIcJqEm/e vWeE2Cou8bfhEdSZvBIz2p+yQNhyEtO+rmGGsKUlzs/awAhz/uLvj6Hi/BLHbu+Aul5AYuqZ g1A1WhIHV12AmsMnsWbhWxaY+l2nljPD7Lq/ZS5Ur4TE1pYnYCczCyhKTOl+yA5yMrOApsT6 XfqoPgGxPSWuL/vGCtH6l12i8xozJKAEJL5NPsQygVFxFpKWWUimzkKYiqxkASPLKkbR1ILk guKk9CJTveLE3OLSvHS95PzcTYzAhHD637OJOxjvH7A+xCjAwajEw7vgek+oEGtiWXFl7iFG U6DNE5mlRJPzgWknryTe0NjMyMLUxNTYyNzSTEmcV0f6Z7CQQHpiSWp2ampBalF8UWlOavEh RiYOTqkGRravypOUPymWPF1lYPj7Y9hUvSVMnf96wuYuNj3CX+7wZefah4KPzB3zZK1nnBb8 dKW3fIfKfwmvlyfM9uzp/n33vtrhZ49/q+07HcNoF9D+2CD0/x3pouaD+i+7m+xfpnBdfzX7 4oT3My6ubU2bonBrT9B+T+fApN5MyYAqpjMM38+b+rz7+UGJpTgj0VCLuag4EQAdY0hdAwMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGKsWRmVeSWpSXmKPExsVy+t/tfl1L5t5Qg6tTrCwu75rD5sDo8XmT XABjVJpNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBQ JYWyxJxSoFBAYnGxkr6dTVF+aUmqQkZ+cYmtUrShuZGekYGeqZGeoWmslaGBgZEpUE1CWsbf Z3fYC3axVbTPXcDSwLiArYuRk0NIQF3iyuYz7CC2hICJxNa1z6FsMYkL99ZD1cxhlDh3PwjE ZhFQlThw4ydYDRtQ/atDO1lBbGEBO4kFR0+zdDFycIgIZEk8PmgO0aok8fnSHrASXgFBiZMz n4CVSACN2bM4FyKsJvHm3XtGiK3iEn8bHkFdwCsxo/0pC4QtJzHt6xpmCFta4vysDYwwVy7+ /hgqzi9x7PYOJghbQGLqmYNQNVoSB1ddgJrDJ7Fm4VsWmPpdp5Yzw+y6v2UuVK+ExNaWJ2An MwsoSkzpfsgOcjKzgKbE+l36qD4BsT0lri/7xjqBUWYWktQsJN2zELqRlSxgZFnFKJpakFxQ nJReYaJXnJhbXJqXrpecn7uJEZxmni3ZwdhwwfoQowAHoxIPb8CdnlAh1sSy4srcQ4wSHMxK IryP/wCFeFMSK6tSi/Lji0pzUosPMZoCY2kis5Rocj4wBeaVxBsam5ibGptaGBiam5spifP+ P5cbIiSQnliSmp2aWpBaBNPHxMEp1cA4We2bG/v1EkEuw1W93VkezZfkFuW0nfVflqSxc4/4 0mfBH3/a/RR8cjBk85RIn9um7bOdXvS8NitlvrxzdXy/TXikopXCZO0lBt5myqc/nK4xYVf8 ZpUa9+2zrrbEet078xpO6Tq6vfFouPnQ5upLFj+tOFvu+Gu7LeWndv/++djyQdtm8UYlluKM REMt5qLiRADa8qzeSQMAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t5Q7kHf9028060 EP-EC562D6B53594479BCA6FC73F17DEE54 In error condition, td buffer is not freed which can lead to memory leak. Signed-off-by: Vivek Kumar Bhagat --- drivers/usb/host/xhci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 36bf089..dc02532 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -1438,6 +1438,7 @@ dying: ret = -ESHUTDOWN; free_priv: xhci_urb_free_priv(urb_priv); + kfree(buffer); urb->hcpriv = NULL; spin_unlock_irqrestore(&xhci->lock, flags); return ret; -- 1.7.9.5{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I