* [PATCH] nfp: xsk: avoid newline at the end of message in NL_SET_ERR_MSG_MOD
@ 2022-03-07 9:07 Guo Zhengkui
2022-03-07 9:27 ` Niklas Söderlund
2022-03-07 12:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Guo Zhengkui @ 2022-03-07 9:07 UTC (permalink / raw)
To: Simon Horman, Jakub Kicinski, David S. Miller,
Niklas Söderlund, Louis Peens, Yinjun Zhang, Guo Zhengkui,
Paolo Abeni, open list:NETRONOME ETHERNET DRIVERS,
open list:NETWORKING DRIVERS, open list
Fix the following coccicheck warning:
drivers/net/ethernet/netronome/nfp/nfp_net_common.c:3434:8-48: WARNING
avoid newline at end of message in NL_SET_ERR_MSG_MOD
Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
index 00a09b9e0aee..d5ff80a62882 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
@@ -3431,7 +3431,7 @@ nfp_net_check_config(struct nfp_net *nn, struct nfp_net_dp *dp,
if (xsk_pool_get_rx_frame_size(dp->xsk_pools[r]) < xsk_min_fl_bufsz) {
NL_SET_ERR_MSG_MOD(extack,
- "XSK buffer pool chunk size too small\n");
+ "XSK buffer pool chunk size too small");
return -EINVAL;
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] nfp: xsk: avoid newline at the end of message in NL_SET_ERR_MSG_MOD
2022-03-07 9:07 [PATCH] nfp: xsk: avoid newline at the end of message in NL_SET_ERR_MSG_MOD Guo Zhengkui
@ 2022-03-07 9:27 ` Niklas Söderlund
2022-03-07 12:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2022-03-07 9:27 UTC (permalink / raw)
To: Guo Zhengkui
Cc: Simon Horman, Jakub Kicinski, David S. Miller, Louis Peens,
Yinjun Zhang, Paolo Abeni, open list:NETRONOME ETHERNET DRIVERS,
open list:NETWORKING DRIVERS, open list
Hi Guo,
Thanks for your work.
On 2022-03-07 17:07:59 +0800, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c:3434:8-48: WARNING
> avoid newline at end of message in NL_SET_ERR_MSG_MOD
>
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> ---
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> index 00a09b9e0aee..d5ff80a62882 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> @@ -3431,7 +3431,7 @@ nfp_net_check_config(struct nfp_net *nn, struct nfp_net_dp *dp,
>
> if (xsk_pool_get_rx_frame_size(dp->xsk_pools[r]) < xsk_min_fl_bufsz) {
> NL_SET_ERR_MSG_MOD(extack,
> - "XSK buffer pool chunk size too small\n");
> + "XSK buffer pool chunk size too small");
> return -EINVAL;
> }
> }
> --
> 2.20.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] nfp: xsk: avoid newline at the end of message in NL_SET_ERR_MSG_MOD
2022-03-07 9:07 [PATCH] nfp: xsk: avoid newline at the end of message in NL_SET_ERR_MSG_MOD Guo Zhengkui
2022-03-07 9:27 ` Niklas Söderlund
@ 2022-03-07 12:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-07 12:10 UTC (permalink / raw)
To: Guo Zhengkui
Cc: simon.horman, kuba, davem, niklas.soderlund, louis.peens,
yinjun.zhang, pabeni, oss-drivers, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Mon, 7 Mar 2022 17:07:59 +0800 you wrote:
> Fix the following coccicheck warning:
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c:3434:8-48: WARNING
> avoid newline at end of message in NL_SET_ERR_MSG_MOD
>
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
> ---
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- nfp: xsk: avoid newline at the end of message in NL_SET_ERR_MSG_MOD
https://git.kernel.org/netdev/net-next/c/0c1794c200e9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-07 12:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-07 9:07 [PATCH] nfp: xsk: avoid newline at the end of message in NL_SET_ERR_MSG_MOD Guo Zhengkui
2022-03-07 9:27 ` Niklas Söderlund
2022-03-07 12:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox