From: Mark Brown <broonie@kernel.org>
To: Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Florian Meier <florian.meier@koalo.de>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Liam Girdwood <lgirdwood@gmail.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
Miaoqian Lin <linmq006@gmail.com>
Subject: Re: [PATCH v2] ASoC: atmel: Fix error handling in snd_proto_probe
Date: Tue, 08 Mar 2022 17:20:58 +0000 [thread overview]
Message-ID: <164676005819.54315.3431589094288420530.b4-ty@kernel.org> (raw)
In-Reply-To: <20220308013949.20323-1-linmq006@gmail.com>
On Tue, 8 Mar 2022 01:39:48 +0000, Miaoqian Lin wrote:
> The device_node pointer is returned by of_parse_phandle() with refcount
> incremented. We should use of_node_put() on it when done.
>
> This function only calls of_node_put() in the regular path.
> And it will cause refcount leak in error paths.
> Fix this by calling of_node_put() in error handling too.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: atmel: Fix error handling in snd_proto_probe
commit: b0bfaf0544d08d093d6211d7ef8816fb0b5b6c75
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
prev parent reply other threads:[~2022-03-08 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 13:04 [PATCH] ASoC: atmel: Fix error handling in snd_proto_probe Miaoqian Lin
2022-03-07 13:45 ` Codrin.Ciubotariu
2022-03-08 1:39 ` [PATCH v2] " Miaoqian Lin
2022-03-08 17:20 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164676005819.54315.3431589094288420530.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=claudiu.beznea@microchip.com \
--cc=codrin.ciubotariu@microchip.com \
--cc=florian.meier@koalo.de \
--cc=lgirdwood@gmail.com \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox