[PATCH V2] net: mv643xx_eth: undo some opreations in mv643xx_eth_probe

cgel.zte
2022-03-16T01:24:55Z

From: Minghao Chi <chi.minghao@zte.com.cn>

Cannot directly return platform_get_irq return irq, there
are operations that need to be undone.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
v1->v2:
- Use goto out;
drivers/net/ethernet/marvell/mv643xx_eth.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
index e6cd4e214d79..5f9ab1842d49 100644
--- a/drivers/net/ethernet/marvell/mv643xx_eth.c
+++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
@@ -3189,8 +3189,10 @@ static int mv643xx_eth_probe(struct platform_device *pdev)

irq = platform_get_irq(pdev, 0);
- if (WARN_ON(irq < 0))
- return irq;
+ if (WARN_ON(irq < 0)) {
+ err = irq;
+ goto out;
+ }
dev->irq = irq;

dev->netdev_ops = &mv643xx_eth_netdev_ops;
--
2.25.1