From: Rob Herring <robh@kernel.org>
To: Axe Yang <axe.yang@mediatek.com>
Cc: Tian Tao <tiantao6@hisilicon.com>,
Ulf Hansson <ulf.hansson@linaro.org>, Yue Hu <huyue2@yulong.com>,
linux-arm-kernel@lists.infradead.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Andrew Jeffery <andrew@aj.id.au>,
angelogioacchino.delregno@collabora.com,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rob Herring <robh+dt@kernel.org>,
Eric Biggers <ebiggers@google.com>,
Satya Tangirala <satyat@google.com>,
Stephen Boyd <swboyd@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chaotian Jing <chaotian.jing@mediatek.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
linux-mediatek@lists.infradead.org, Lucas Stach <dev@lynxeye.de>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Kiwoong Kim <kwmad.kim@samsung.com>
Subject: Re: [RESEND v7 1/3] dt-bindings: mmc: mtk-sd: extend interrupts and pinctrls properties
Date: Sat, 19 Mar 2022 20:13:33 -0600 [thread overview]
Message-ID: <1647742413.962309.2990518.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220317101215.24985-2-axe.yang@mediatek.com>
On Thu, 17 Mar 2022 18:12:13 +0800, Axe Yang wrote:
> Extend interrupts and pinctrls for SDIO wakeup interrupt feature.
> This feature allow SDIO devices alarm asynchronous interrupt to host
> even when host stop providing clock to SDIO card. An extra wakeup
> interrupt and pinctrl states for SDIO DAT1 pin state switching are
> required in this scenario.
>
> Signed-off-by: Axe Yang <axe.yang@mediatek.com>
> ---
> .../devicetree/bindings/mmc/mtk-sd.yaml | 24 ++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/mtk-sd.yaml: properties:pinctrl-names: {'description': 'Should at least contain default and state_uhs. To support SDIO in-band wakeup, dat1 pin will be switched between GPIO mode and SDIO DAT1 mode, state_eint and state_dat1 are mandatory in this scenarios.', 'minItems': 2, 'maxItems': 4, 'items': [{'const': 'default'}, {'const': 'state_uhs'}, {'const': 'state_eint'}, {'const': 'state_dat1'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/mtk-sd.yaml: ignoring, error in schema: properties: pinctrl-names
Documentation/devicetree/bindings/mmc/mtk-sd.example.dt.yaml:0:0: /example-0/mmc@11230000: failed to match any schema with compatible: ['mediatek,mt8173-mmc']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1606491
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-03-20 2:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 10:12 [RESEND v7 0/3] mmc: mediatek: add support for SDIO async IRQ Axe Yang
2022-03-17 10:12 ` [RESEND v7 1/3] dt-bindings: mmc: mtk-sd: extend interrupts and pinctrls properties Axe Yang
2022-03-18 13:30 ` Krzysztof Kozlowski
2022-03-20 2:13 ` Rob Herring [this message]
2022-03-21 4:17 ` Miles Chen
2022-03-21 11:54 ` Axe Yang
2022-03-17 10:12 ` [RESEND v7 2/3] mmc: core: Add support for SDIO wakeup interrupt Axe Yang
2022-03-17 10:12 ` [RESEND v7 3/3] mmc: mediatek: add support for SDIO eint wakup IRQ Axe Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1647742413.962309.2990518.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=andrew@aj.id.au \
--cc=andriy.shevchenko@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=axe.yang@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=dev@lynxeye.de \
--cc=devicetree@vger.kernel.org \
--cc=ebiggers@google.com \
--cc=huyue2@yulong.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=satyat@google.com \
--cc=swboyd@chromium.org \
--cc=tiantao6@hisilicon.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox