From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753851AbcEMWO6 (ORCPT ); Fri, 13 May 2016 18:14:58 -0400 Received: from gloria.sntech.de ([95.129.55.99]:40004 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753536AbcEMWO5 (ORCPT ); Fri, 13 May 2016 18:14:57 -0400 From: Heiko Stuebner To: Brian Norris Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Doug Anderson , Shawn Lin , Brian Norris Subject: Re: [PATCH v2 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399 Date: Sat, 14 May 2016 00:14:40 +0200 Message-ID: <1647746.RHuiZHceXs@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <20160513215724.GB109473@google.com> References: <1463092552-60696-1-git-send-email-briannorris@chromium.org> <5607915.FAWxOoA1QB@phil> <20160513215724.GB109473@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 13. Mai 2016, 14:57:24 schrieb Brian Norris: > On Fri, May 13, 2016 at 11:47:57PM +0200, Heiko Stuebner wrote: > > Am Donnerstag, 12. Mai 2016, 15:35:51 schrieb Brian Norris: > > > Add description for the SDHCI v5.1 eMMC controller on rk3399. Fix it > > > to > > > 200 MHz, to support all supported timing modes. > > > > > > Note that 'rockchip,rk3399-sdhci-5.1' is not documented; we presumably > > > have a compliant Arasan controller, but let's have a rockchip property > > > as the canonical backup/precautionary measure. Per Heiko's previous > > > suggestion, let's not clutter the arasan doc with it. > > > > > > Signed-off-by: Brian Norris > > > > At least one split is necessary. > > So please at least split out the simple-mfd addition into a separate > > patch > Will do. > > BTW, should this be noted in > Documentation/devicetree/bindings/soc/rockchip/grf.txt now? The simple-mfd is already documented in mfd/mfd.txt in a general way, so I don't think every instance needs to have that, especially as it mainly affects sub-nodes alone.