From: Christoph Paasch <christoph.paasch@uclouvain.be>
To: Piotr Sawuk <a9702387@unet.univie.ac.at>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: resurrecting tcphealth
Date: Mon, 16 Jul 2012 17:24:37 +0200 [thread overview]
Message-ID: <1648678.899sL4YBmA@cpaasch-mac> (raw)
In-Reply-To: <436a23ea8f8df4e8e3c71c369f1e3649.squirrel@webmail.univie.ac.at>
On Monday 16 July 2012 17:12:26 Piotr Sawuk wrote:
> + seq_printf(seq, "%d: %-21pI4:%u %-21pI4:%u "
> + "%8u %8lu %8lu %8lu %8lu%n",
> + st->num,
> + &inet->inet_rcv_saddr,
> + ntohs(inet->inet_sport),
> + &inet->inet_daddr,
> + ntohs(inet->inet_dport),
> + jiffies_to_msecs(tp->srtt),
This still doesn't gives you the correct RTT.
srtt is in jiffies * 8.
You should do jiffies_to_msecs(tp->srtt) >> 3.
The RTT is already exposed by tcp_info anyway... (see tcp_get_info() - where
you also see the bitshift)
Christoph
--
IP Networking Lab --- http://inl.info.ucl.ac.be
MultiPath TCP in the Linux Kernel --- http://mptcp.info.ucl.ac.be
Université Catholique de Louvain
--
next prev parent reply other threads:[~2012-07-16 15:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-14 7:56 resurrecting tcphealth Piotr Sawuk
2012-07-14 8:27 ` Eric Dumazet
2012-07-14 19:29 ` David Miller
2012-07-16 13:32 ` Ben Hutchings
2012-07-16 15:12 ` Piotr Sawuk
2012-07-16 15:24 ` Christoph Paasch [this message]
2012-07-19 10:37 ` Piotr Sawuk
-- strict thread matches above, loose matches on Subject: below --
2012-07-13 7:33 Piotr Sawuk
2012-07-13 23:55 ` Stephen Hemminger
2012-07-14 1:31 ` valdis.kletnieks
2012-07-16 11:33 ` Piotr Sawuk
2012-07-16 11:46 ` Eric Dumazet
2012-07-16 13:03 ` Piotr Sawuk
2012-07-20 14:06 ` Yuchung Cheng
2012-07-21 10:34 ` Piotr Sawuk
2012-07-12 20:55 Piotr Sawuk
2012-07-12 21:35 ` Stephen Hemminger
2012-07-12 22:29 ` Randy Dunlap
2012-07-14 21:48 ` Stephen Hemminger
2012-07-14 23:43 ` Piotr Sawuk
2012-07-15 7:16 ` Eric Dumazet
2012-07-15 9:17 ` Piotr Sawuk
2012-07-15 9:53 ` Eric Dumazet
2012-07-15 22:17 ` Piotr Sawuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1648678.899sL4YBmA@cpaasch-mac \
--to=christoph.paasch@uclouvain.be \
--cc=a9702387@unet.univie.ac.at \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox