Re: [PATCH 06/10] ARM: dts: qcom: msm8974: override nodes by label

Krzysztof Kozlowski
2022-04-18T15:42:41Z

On 01/04/2022 22:10, Krzysztof Kozlowski wrote:
> Using node paths to extend or override a device tree node is error
> prone. If there was a typo error, a new node will be created instead of
> extending the existing node. This will lead to run-time errors that
> could be hard to detect.
>
> A mistyped label on the other hand, will cause a dtc compile error
> (during build time). This also reduces the indentation making the code
> easier to read.
>
> Re-order the overrides by label name. The pre/post DTBS are the same.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 614 +++++-----
> .../boot/dts/qcom-msm8974-fairphone-fp2.dts | 581 +++++----
> .../qcom-msm8974-lge-nexus5-hammerhead.dts | 1075 ++++++++--------
> .../boot/dts/qcom-msm8974-samsung-klte.dts | 1083 ++++++++---------
> .../dts/qcom-msm8974-sony-xperia-amami.dts | 569 +++++----
> .../dts/qcom-msm8974-sony-xperia-castor.dts | 908 +++++++-------
> .../dts/qcom-msm8974-sony-xperia-honami.dts | 636 +++++-----
> arch/arm/boot/dts/qcom-msm8974.dtsi | 16 +-
> 8 files changed, 2730 insertions(+), 2752 deletions(-)
>

Hi Bjorn,

I see you applied other arm-dts patches from this set, except this one.
Any comments here? This is quite a big one, so maybe it had trouble
making through the discussion lists?

Best regards,
Krzysztof