public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "cy_huang(黃啟原)" <cy_huang@richtek.com>
To: "axel.lin@ingics.com" <axel.lin@ingics.com>,
	"broonie@kernel.org" <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: rtq2134: Fix missing active_discharge_on setting
Date: Wed, 6 Apr 2022 01:47:10 +0000	[thread overview]
Message-ID: <1649209630.3282.2.camel@richtek.com> (raw)
In-Reply-To: <20220404022514.449231-1-axel.lin@ingics.com>

於 一,2022-04-04 於 10:25 +0800,Axel Lin 提到:
> The active_discharge_on setting was missed, so output discharge resistor
> is always disabled. Fix it.
>
> Fixes: 0555d41497de ("regulator: rtq2134: Add support for Richtek RTQ2134
> SubPMIC")
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/regulator/rtq2134-regulator.c | 1 +
>  1 file changed, 1 insertion(+)
>
Hi, Axel:
Thanks for the fix.

> diff --git a/drivers/regulator/rtq2134-regulator.c
> b/drivers/regulator/rtq2134-regulator.c
> index f21e3f8b21f2..8e13dea354a2 100644
> --- a/drivers/regulator/rtq2134-regulator.c
> +++ b/drivers/regulator/rtq2134-regulator.c
> @@ -285,6 +285,7 @@ static const unsigned int rtq2134_buck_ramp_delay_table[]
> = {
>  .enable_mask = RTQ2134_VOUTEN_MASK, \
>  .active_discharge_reg = RTQ2134_REG_BUCK##_id##_CFG0, \
>  .active_discharge_mask = RTQ2134_ACTDISCHG_MASK, \
> +.active_discharge_on = RTQ2134_ACTDISCHG_MASK, \
>  .ramp_reg = RTQ2134_REG_BUCK##_id##_RSPCFG, \
>  .ramp_mask = RTQ2134_RSPUP_MASK, \
>  .ramp_delay_table = rtq2134_buck_ramp_delay_table, \
************* Email Confidentiality Notice ********************

The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!

      parent reply	other threads:[~2022-04-06 10:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-04  2:25 [PATCH] regulator: rtq2134: Fix missing active_discharge_on setting Axel Lin
2022-04-05  9:32 ` Mark Brown
2022-04-06  1:47 ` cy_huang(黃啟原) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1649209630.3282.2.camel@richtek.com \
    --to=cy_huang@richtek.com \
    --cc=axel.lin@ingics.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox