Re: [PATCH 1/2] ARM: dts: rockchip: Split GPIO keys for veyron into multiple devices

Heiko Stuebner
2019-06-06T10:44:40Z

Am Mittwoch, 5. Juni 2019, 22:43:19 CEST schrieb Matthias Kaehlcke:
> With a single device DT overrides can become messy, especially when
> keys are added or removed. Multiple devices also allow to
> enable/disable wakeup per key/group.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>

applied for 5.3 with 2 minor changes, detailed below.

> ---
> .../boot/dts/rk3288-veyron-chromebook.dtsi | 26 +++++++------
> arch/arm/boot/dts/rk3288-veyron-minnie.dts | 38 ++++++++++---------
> arch/arm/boot/dts/rk3288-veyron-pinky.dts | 2 +-
> arch/arm/boot/dts/rk3288-veyron.dtsi | 4 +-
> 4 files changed, 37 insertions(+), 33 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
> index fbef34578100..c5f71af84a40 100644
> --- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
> @@ -70,6 +70,20 @@
> pinctrl-0 = <&ac_present_ap>;
> };
>
> + lid_switch: lid-switch {
> + compatible = "gpio-keys";
> + pinctrl-names = "default";
> + pinctrl-0 = <&ap_lid_int_l>;

added a blank line here

> + lid {
> + label = "Lid";
> + gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_LOW>;
> + wakeup-source;
> + linux,code = <0>; /* SW_LID */
> + linux,input-type = <5>; /* EV_SW */

actually used the constants in the properties, we have the keycodes as
dt-binding header nowadays.

Heiko